Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt displayPercentage to scene with SliverPersistentHeader #43

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: adapt displayPercentage to scene with SliverPersistentHeader #43

merged 1 commit into from
Aug 25, 2023

Conversation

percival888
Copy link
Contributor

fix issue #42

@percival888 percival888 changed the title fix: adapt displayPercentage for scene with SliverPersistentHeader fix: adapt displayPercentage to scene with SliverPersistentHeader Aug 25, 2023
@LinXunFeng LinXunFeng self-requested a review August 25, 2023 14:54
LinXunFeng
LinXunFeng reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@LinXunFeng LinXunFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nit about formatting

example/lib/features/custom_scrollview/sliver_appbar_demo/sliver_appbar_demo_page.dart Show resolved Hide resolved
@LinXunFeng LinXunFeng merged commit 4bae325 into fluttercandies:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinXunFeng LinXunFeng LinXunFeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@percival888 @LinXunFeng