Skip to content

Commit

Permalink
gstreamer1.0-plugins-bad: fix the logic to set GL option in -bad
Browse files Browse the repository at this point in the history
The purpose of this .bbappend file is to enable the right GL config option in
Gstreamer -bad plugins for qcom based chipset. The current logic was broken:
when building with no x11 and no wayland in DISTRO_FEATURES we would set
PACKAGECONFIG_GL to opengl which is wrong, since opengl depends on x11 (in
-bad). So the right thing to do is to set it to opengl is x11 is in
DISTRO_FEATURES and gles2 otherwise, e.g. when building for wayland only (no
X11) and for use cases such as Qt5/EGLFS that does not use x11 nor wayland.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
  • Loading branch information
ndechesne committed Nov 8, 2016
1 parent 94d0a8d commit 7be7a1c
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
GST_BAD_OPENGL_FEATURES= "${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'gles2', 'opengl', d)}"
GST_BAD_OPENGL_FEATURES= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'opengl', 'gles2', d)}"

# We want OpenGL with freedreno for our machines
PACKAGECONFIG_GL_apq8064 = "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', '${GST_BAD_OPENGL_FEATURES}', '', d)}"
Expand Down

0 comments on commit 7be7a1c

Please sign in to comment.