Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcamera with CPU SoftISP into initramfs-test-full-image #584

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0xB0D
Copy link
Contributor

@0xB0D 0xB0D commented Mar 27, 2024

This is the WIP branch for SoftISP debayering in libcamera.

At some stage in the hopefully not too distant future libcamera 0.3 upstream will merge this branch and we can probably drop the bbappend.

Either way it'd be nice to include libcamera and the "cam" util in the initramfs.

Once built a superficial example of usage is

cam -c 1 --capture=10 --file

Obviously more complex and interesting things can be done - all of the RPI camera stuff goes through libcamera so we very much want to follow this on the qcom side.

Copy link
Collaborator

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the bbappend to dynamic-layers/multimedia-layer/recipes-multimedia.

LIC_FILES_CHKSUM = "\
file://LICENSES/GPL-2.0-or-later.txt;md5=fed54355545ffd980b814dab4a3b312c \
file://LICENSES/LGPL-2.1-or-later.txt;md5=2a4f4fd2128ea2f65047ee63fbca9f68 \
"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be necessary, it matches what I see in the libcamera_0.2.0.bb

@@ -33,6 +33,7 @@ PACKAGE_INSTALL_openembedded-layer += " \
gpsd-machine-conf \
gps-utils \
iozone3 \
libcamera \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main libcamera recipe is in meta-multimedia, not in meta-oe, so please move it ti PACKAGE_INSTALL_multimedia-layer.

0xB0D added 2 commits May 1, 2024 19:28
libcamera provides a means to configure a CAMSS pipeline and to do debayer
and 3A in the CPU.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
The SoftISP branch provides debayering and 3a using CPU algorithms. This
gives us a "real picture we can use" on qcom hardware absent the HardISP.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
@0xB0D 0xB0D force-pushed the master+libcamera-softisp branch from 43bc057 to 6b92c56 Compare May 1, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants