-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux-yocto: enable display on QCM6490 IDP board #593
Open
TanguduSrihitha
wants to merge
5
commits into
Linaro:master
Choose a base branch
from
TanguduSrihitha:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2f1a193
linux-yocto: Add Novatek NT36672E LCD DSI panel
TanguduSrihitha 58fe022
linux-yocto: compile NT36672E panel and backlight PWM as built-in
TanguduSrihitha 9b854a7
linux-yocto: Add support for PM7250B PMIC on QCM6490 IDP board
TanguduSrihitha 92c69f7
linux-yocto: add display and panel on QCM6490 IDP board
TanguduSrihitha 82b074a
linux-yocto: disable GPU on QCM6490 IDP board
TanguduSrihitha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
32 changes: 32 additions & 0 deletions
32
...ux/linux-yocto/qcm6490-board-dts/0001-DENIED-arm64-dts-qcom-qcm6490-idp-disable-gpu.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| From fe56e57b5ef4b50e75613e553e2f7609aa1ef1db Mon Sep 17 00:00:00 2001 | ||
| From: Vinod Polimera <vpolimer@qti.qualcomm.com> | ||
| Date: Fri, 10 May 2024 11:41:59 +0530 | ||
| Subject: [PATCH] DENIED: arm64: dts: qcom: qcm6490-idp: disable gpu | ||
|
|
||
| Disable GPU to avoid adreno errors during display commit as there is | ||
| no plan to enable GPU rendering in near future on QCM6490 IDP board. | ||
|
|
||
| Signed-off-by: Srihitha Tangudu <quic_tangudu@quicinc.com> | ||
| Upstream-Status: Denied [https://lore.kernel.org/all/99a9a562-9f6f-411c-be1c-0a28fc2524dd@quicinc.com/] | ||
| --- | ||
| arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 4 ++++ | ||
| 1 file changed, 4 insertions(+) | ||
|
|
||
| diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts | ||
| index 62cdee7a8156..4b898b441a0b 100644 | ||
| --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts | ||
| +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts | ||
| @@ -438,6 +438,10 @@ vreg_bob_3p296: bob { | ||
| }; | ||
| }; | ||
|
|
||
| +&gpu { | ||
| + status = "disabled"; | ||
| +}; | ||
| + | ||
| &mdss { | ||
| status = "okay"; | ||
| }; | ||
| -- | ||
| 2.34.1 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply: NAK. The GPU is present onboard, so there is no need to disable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover, per Ritesh's email this patch is not necessary at all. GPU works on this platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few of the Conrad's Adreno 643+ fixes are yet to be backported. We are in discussion with our GPU team regarding the same and adreno firmware loading enablement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPU on SC7280 has been supported upstream since 5.16. ZAP shader has been supported for ages. I fail to see what is so special about the QCM6490 which is supposed to be very close to SC7280.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, yes, please backport the patches and provide the firmware for the board.