[PATCH v12] one more try to add nice stats for Shippable #309

muvarov · 2017-11-24T10:16:49Z

No description provided.

lumag · 2017-11-24T11:11:20Z

test/common/odp_cunit_common.c

 #include <odp_api.h>
 #include "odp_cunit_common.h"
 #include <odp/helper/odph_api.h>
 /* Globals */
 static odph_odpthread_t thread_tbl[MAX_WORKERS];
 static odp_instance_t instance;

+extern const char *__progname;


Please use a copy of argv[0] instead of progname.

save argv[0] in some global variable?

@muvarov yes

lumag · 2017-11-24T11:12:00Z

test/common/odp_cunit_common.c

+	}
+
+	CU_automated_run_tests();
+#else


This should be refactored to a function which is selected basing on TEST_CUNIT_XML, rather than having #ifdef directly in the function body.

@muvarov I still do not like this piece. Maybe you can add a runtime switch through environment variable? Then there will be no requirement for extra AM_CONDITIONAL/AC_DEFINE

lumag · 2017-11-24T11:12:27Z

test/m4/validation.m4

+AC_ARG_ENABLE([cunit_out_xml],
+    [AS_HELP_STRING([--enable-cunit_out_xml],
+		    [include additional debugging code ]
+		    [(set to 'full' to enable all --enable-*-debug-* options)])],


This is just incorrect

yep, thanks it's copy paste text

lumag · 2017-11-24T11:14:59Z

test/Makefile.inc

@@ -17,6 +17,9 @@ INCFLAGS = \

 AM_CPPFLAGS = $(INCFLAGS)
 AM_CFLAGS = $(CUNIT_CFLAGS)
+if cunit_out_xml
+AM_CFLAGS  += -DTEST_CUNIT_XML
+endif


This looks like an overkill. I'd suggest to use Autoconf variable rather than Automake conditional here.

muvarov · 2017-11-27T14:30:02Z

@ttrahan this PR adds Junit stats and copies it to results directory. But I think parsing script needs to be adjusted to support that output. I do not see that stats are updated.

lumag · 2017-12-11T22:00:49Z

test/m4/validation.m4

+    [AS_HELP_STRING([--enable-cunit_out_xml],
+		    [output to xml]
+		    [(output test results to xml instead of plain text)])],
+		    cunit_out_xml=yes, cunit_out_xml=no)


Ideally this should also be escaped with square brackets.

lumag · 2017-12-11T22:03:09Z

test/common/odp_cunit_common.c

+	}
+
+	CU_automated_run_tests();
+#else


@muvarov I still do not like this piece. Maybe you can add a runtime switch through environment variable? Then there will be no requirement for extra AM_CONDITIONAL/AC_DEFINE

lumag · 2017-12-11T22:06:02Z

test/common/odp_cunit_common.h

+#include <CUnit/TestDB.h>
+#if TEST_CUNIT_XML
+#include <CUnit/Automated.h>
+#endif


No need to hide it under #if

our arm tests use some previous version where function declared as finc(); i.e. not func(void) and gcc fails on it. In task which run inside Shippable it's corrected.

@muvarov then it's better to update CUnit version on target, rather than workaround its bugs.

lumag · 2017-12-11T22:06:24Z

test/m4/validation.m4

+      [TEST_CUNIT_XML=0])
+AC_DEFINE_UNQUOTED([TEST_CUNIT_XML], [$TEST_CUNIT_XML],
+		   [Define to 1 to output to xml])
+AM_CONDITIONAL([cunit_out_xml], [test "x$cunit_out_xml" = "xyes"])


Conditional is unused

muvarov · 2017-12-14T14:37:02Z

@lumag fixed comments. This version has to show counters. For Cunit I think we only can fix header because it's already the latest release. I added comment to travis. Please take a look.

muvarov · 2017-12-14T15:18:09Z

Travis fails here due to caches for cunit. After merge it has to be ok. Clean run is here:
https://travis-ci.org/muvarov/odp/builds/316450770

muvarov · 2017-12-19T11:25:42Z

@lumag ping.

lumag · 2017-12-19T11:43:26Z

@muvarov still an #ifdef inside function code. I really suggest to move xml/plain output type to test arguments.

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

Pass args to cunit to make code commong with other tests. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

some gcc fails on including this header but cunit is the latest stable release. So fix it in place until it will not be fixed upstream. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

muvarov · 2017-12-20T15:17:25Z

v12: switched to getenv() instead of ifdefs as agreed.

lumag · 2017-12-20T15:54:02Z

Reviewed-by: Dmitry Eremin-Solenikov

muvarov · 2017-12-21T15:59:15Z

Merged.

muvarov changed the title ~~one more try to add nice stats for Shippable~~ [PATCH v1] one more try to add nice stats for Shippable Nov 24, 2017

muvarov force-pushed the devel/master_shippable2 branch from c0e0184 to 3f3d0b1 Compare November 24, 2017 10:55

muvarov changed the title ~~[PATCH v1] one more try to add nice stats for Shippable~~ [PATCH v2] one more try to add nice stats for Shippable Nov 24, 2017

muvarov added Email_sent labels Nov 24, 2017

lumag suggested changes Nov 24, 2017

View reviewed changes

muvarov force-pushed the devel/master_shippable2 branch from 3f3d0b1 to 20b050e Compare November 24, 2017 12:14

muvarov changed the title ~~[PATCH v2] one more try to add nice stats for Shippable~~ [PATCH v3] one more try to add nice stats for Shippable Nov 24, 2017

muvarov added Email_sent and removed Email_sent labels Nov 24, 2017

muvarov force-pushed the devel/master_shippable2 branch from 20b050e to 6edcb07 Compare November 27, 2017 13:42

muvarov changed the title ~~[PATCH v3] one more try to add nice stats for Shippable~~ [PATCH v4] one more try to add nice stats for Shippable Nov 27, 2017

muvarov added Email_sent and removed Email_sent labels Nov 27, 2017

muvarov force-pushed the devel/master_shippable2 branch from 6edcb07 to 6afa711 Compare December 7, 2017 16:31

muvarov changed the title ~~[PATCH v4] one more try to add nice stats for Shippable~~ [PATCH v5] one more try to add nice stats for Shippable Dec 7, 2017

muvarov added Email_sent and removed Email_sent labels Dec 7, 2017

muvarov force-pushed the devel/master_shippable2 branch from 6afa711 to d5e6740 Compare December 8, 2017 13:06

muvarov changed the title ~~[PATCH v5] one more try to add nice stats for Shippable~~ [PATCH v6] one more try to add nice stats for Shippable Dec 8, 2017

muvarov added Email_sent and removed Email_sent labels Dec 8, 2017

lumag suggested changes Dec 11, 2017

View reviewed changes

lumag reviewed Dec 11, 2017

View reviewed changes

muvarov force-pushed the devel/master_shippable2 branch from 0e4f68a to 02634e0 Compare December 14, 2017 14:35

muvarov changed the title ~~[PATCH v9] one more try to add nice stats for Shippable~~ [PATCH v10] one more try to add nice stats for Shippable Dec 14, 2017

muvarov removed Email_sent labels Dec 14, 2017

muvarov added Email_sent labels Dec 14, 2017

muvarov added 3 commits December 20, 2017 17:20

test: build: enable cunit output to xml

275c854

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

linux-gen:test: shmem pass args to cunit

ffeeec3

Pass args to cunit to make code commong with other tests. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

test: cunit common fix header paths

697de31

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

muvarov force-pushed the devel/master_shippable2 branch from 02634e0 to 4438105 Compare December 20, 2017 15:14

muvarov changed the title ~~[PATCH v10] one more try to add nice stats for Shippable~~ [PATCH v11] one more try to add nice stats for Shippable Dec 20, 2017

muvarov removed Email_sent labels Dec 20, 2017

muvarov added 2 commits December 20, 2017 18:16

shipabble: use xml statistics

9d42787

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

travis: cunit fix function declaration in Automated.h

8936749

some gcc fails on including this header but cunit is the latest stable release. So fix it in place until it will not be fixed upstream. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

muvarov force-pushed the devel/master_shippable2 branch from 4438105 to 8936749 Compare December 20, 2017 15:16

muvarov changed the title ~~[PATCH v11] one more try to add nice stats for Shippable~~ [PATCH v12] one more try to add nice stats for Shippable Dec 20, 2017

muvarov added Email_sent labels Dec 20, 2017

muvarov closed this Dec 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PATCH v12] one more try to add nice stats for Shippable #309

[PATCH v12] one more try to add nice stats for Shippable #309

muvarov commented Nov 24, 2017

lumag Nov 24, 2017

muvarov Nov 27, 2017

lumag Nov 28, 2017

lumag Nov 24, 2017

lumag Dec 11, 2017

lumag Nov 24, 2017

muvarov Nov 27, 2017 •

edited

lumag Nov 24, 2017

muvarov commented Nov 27, 2017

lumag Dec 11, 2017

lumag Dec 11, 2017

lumag Dec 11, 2017

muvarov Dec 11, 2017

lumag Dec 11, 2017

lumag Dec 11, 2017

muvarov commented Dec 14, 2017

muvarov commented Dec 14, 2017

muvarov commented Dec 19, 2017

lumag commented Dec 19, 2017

muvarov commented Dec 20, 2017

lumag commented Dec 20, 2017

muvarov commented Dec 21, 2017

[PATCH v12] one more try to add nice stats for Shippable #309

[PATCH v12] one more try to add nice stats for Shippable #309

Conversation

muvarov commented Nov 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

muvarov Nov 27, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

muvarov commented Nov 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

muvarov commented Dec 14, 2017

muvarov commented Dec 14, 2017

muvarov commented Dec 19, 2017

lumag commented Dec 19, 2017

muvarov commented Dec 20, 2017

lumag commented Dec 20, 2017

muvarov commented Dec 21, 2017

muvarov Nov 27, 2017 •

edited