[PATCH v13] Misc fixes #377

lumag · 2017-12-31T01:25:48Z

Several small fixes produced while working on updating ODP packaging.

libodphelper.so uses symbols from libpthread and libodp-linux.so, link it aganst those libraries. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

Omitting those images in Makefile.am made them disappear from distribution tarball resulting in an improperly-built documentation files. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

Receieved -> Received. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

codecov · 2017-12-31T08:41:20Z

Codecov Report

Merging #377 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##            master      #377   +/-   ##
=========================================
  Coverage   78.677%   78.677%           
=========================================
  Files          196       196           
  Lines        34616     34616           
=========================================
  Hits         27235     27235           
  Misses        7381      7381

Impacted Files	Coverage Δ
test/validation/api/time/time.c	`96.017% <100%> (ø)`	⬆️
test/performance/odp_pktio_ordered.c	`71.138% <0%> (-0.204%)`	⬇️
platform/linux-generic/odp_traffic_mngr.c	`78.98% <0%> (+0.042%)`	⬆️

Bill-Fischofer-Linaro

Reviewed-by: Bill Fischofer bill.fischofer@linaro.org

muvarov · 2018-01-01T20:15:55Z

--disable-static-link should be added to Travis also.

muvarov · 2018-01-01T20:21:03Z

and also status to ./configure output status is needed.

muvarov · 2018-01-01T20:24:16Z

configure.ac

+	      [static_link=$enableval],
+	      [static_link=yes])
+AM_CONDITIONAL([STATIC_LINK], [test "x$static_link" != "xno"])
+


At his time if --disable-static-link is specified then linking is static. If it's not specified that it's dynamic. I'm looking on odp_generator.

Well, no. Please recheck. I will update description to mention that is means static linking of libodp-linux into examples.

lumag · 2018-01-01T20:53:11Z

@muvarov updated

muvarov · 2018-01-01T20:56:26Z

@lumag for v3:

./configure --disable-static-link
make
ldd ./example/generator/odp_generator
	not a dynamic executable

Populate test/Makefile.inc with more variables, allowing us to drop platform test/Makefile.inc. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

LDADD variable can be used to pass other libraries (like DPDK). Stop overriding LDADD entirely. Instead use PRELDADD variable or appending to LDADD. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

lumag · 2018-01-03T21:55:31Z

Using gettimeofday() instead of clock()
Dropped DPDK linkage / no-static-tests for now, will submit in separate PR.

lumag · 2018-01-08T10:59:00Z

@Bill-Fischofer-Linaro @muvarov PR was updated to drop linking PRs. Please review.

muvarov · 2018-01-14T14:22:38Z

example/ipfragreass/Makefile.am

@@ -1,5 +1,7 @@
 include $(top_srcdir)/example/Makefile.inc

+LDADD += $(ATOMIC_LIBS)


This kind of thing which is better to avoid. If we are going to merge odp implementations platforms to common repo then it might be libs which are suitable for linux-generic are not needed for other platform. I think examples Makefiles have to be more common.

This example is not generic enough. It uses atomic primitives directly.

Ok, Than. Agree.

muvarov · 2018-01-14T14:33:36Z

test/validation/api/time/time.c

 	double sec_t, sec_c;
 	odp_time_t sec = time_from_ns(ODP_TIME_SEC_IN_NS);

-	c1 = clock();
+	i = gettimeofday(&tv1, NULL);


gettimeofday() may be changed on NTP/PTP and it's not good for measuring intervals. clock_gettime(CLOCK_MONOTONIC, ...) I think will be good one here.

also please add link to bugz if it's bug fix to git comment.

Nice idea, I will update this PR.

@muvarov maybe we can reenable time_main test in Travis with this fix? What do you think wrt previous issue

@lumag yep, I think it has to pass now.

ODP test for time API uses clock() to compare time against. However clock() returns processor time used by program, which can differ between runs. Use clock_gettime() as a time source to compare against. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org> Fixes: https://bugs.linaro.org/show_bug.cgi?id=3572

This reverts commit 7a7e3ff. After fixing time test to use clock_gettime() instead of clock(), this test should not fail under Travis/coverage. Reenable the test. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

sysconfig is not used in TigerMoth, so let's drop the variable in linux-gen's Makefile. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

libconfig is not used in TigerMoth, so let's drop the variable in test's Makefile.inc. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

ipsec_api example installs program with the same name, as ipsec example does. Remove file conflict between two examples. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

lumag · 2018-01-14T23:43:22Z

@muvarov fixed. Added reference to new time_main bug

There is no need to pass PMDs when linking with shared DPDK library. Just pass -ldpdk which will pick up all PMDS dynamically. When linking with static DPKD library it is required to pass additional libraries after whole PMD string to fix linking when Libtool will reorder flags. So provide just two variables DPDK_LIBS and DPDK_LIBS_LT. Former should be passed directly to gcc, while later should be passed to libtool. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

muvarov · 2018-01-15T20:52:52Z

Merged.

Dmitry Eremin-Solenikov added 4 commits December 31, 2017 02:38

helper: link against libpthread and libodp-linux

48d0c61

libodphelper.so uses symbols from libpthread and libodp-linux.so, link it aganst those libraries. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

doc: add missing user-guide images to Makefile.am

1deacff

Omitting those images in Makefile.am made them disappear from distribution tarball resulting in an improperly-built documentation files. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

doc: add missing implementers-guide images to Makefile.am

65e59b5

Omitting those images in Makefile.am made them disappear from distribution tarball resulting in an improperly-built documentation files. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

performance: odp_crypto: correct typo

4aff7b2

Receieved -> Received. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

muvarov changed the title ~~Misc fixes~~ [PATCH v1] Misc fixes Dec 31, 2017

muvarov added Email_sent labels Dec 31, 2017

lumag force-pushed the misc-fixes branch from 411d5d4 to f84234a Compare December 31, 2017 09:37

muvarov changed the title ~~[PATCH v1] Misc fixes~~ [PATCH v2] Misc fixes Dec 31, 2017

muvarov added Email_sent and removed Email_sent labels Dec 31, 2017

lumag force-pushed the misc-fixes branch from f84234a to 2f944d3 Compare December 31, 2017 13:50

muvarov changed the title ~~[PATCH v2] Misc fixes~~ [PATCH v3] Misc fixes Dec 31, 2017

muvarov added Email_sent and removed Email_sent labels Dec 31, 2017

Bill-Fischofer-Linaro approved these changes Dec 31, 2017

View reviewed changes

muvarov reviewed Jan 1, 2018

View reviewed changes

lumag force-pushed the misc-fixes branch from 2f944d3 to 1dc2d46 Compare January 1, 2018 20:51

muvarov changed the title ~~[PATCH v3] Misc fixes~~ [PATCH v4] Misc fixes Jan 1, 2018

muvarov removed Email_sent labels Jan 1, 2018

Dmitry Eremin-Solenikov added 2 commits January 4, 2018 00:54

test, linux-gen: use common test/Makefile.inc

d38811a

Populate test/Makefile.inc with more variables, allowing us to drop platform test/Makefile.inc. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

validation: stop overriding LDADD variable

0f061b4

LDADD variable can be used to pass other libraries (like DPDK). Stop overriding LDADD entirely. Instead use PRELDADD variable or appending to LDADD. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

lumag force-pushed the misc-fixes branch from f885827 to 3e6e09a Compare January 3, 2018 21:54

muvarov changed the title ~~[PATCH v10] Misc fixes~~ [PATCH v11] Misc fixes Jan 3, 2018

muvarov added Email_sent labels Jan 3, 2018

muvarov reviewed Jan 14, 2018

View reviewed changes

Dmitry Eremin-Solenikov added 5 commits January 15, 2018 02:42

Revert "test: time: do not fail under gcov"

735507c

This reverts commit 7a7e3ff. After fixing time test to use clock_gettime() instead of clock(), this test should not fail under Travis/coverage. Reenable the test. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

linux-gen: don't use SYSCONFDIR

b626e7c

sysconfig is not used in TigerMoth, so let's drop the variable in linux-gen's Makefile. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

tests: don't use ODP_SYSCONFIG_FILE

9aa7f19

libconfig is not used in TigerMoth, so let's drop the variable in test's Makefile.inc. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

example: ipsec_api: remove file conflict with ipsec example

fec9373

ipsec_api example installs program with the same name, as ipsec example does. Remove file conflict between two examples. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

lumag force-pushed the misc-fixes branch from 3e6e09a to fec9373 Compare January 14, 2018 23:42

muvarov changed the title ~~[PATCH v11] Misc fixes~~ [PATCH v12] Misc fixes Jan 14, 2018

muvarov removed Email_sent labels Jan 14, 2018

muvarov added Email_sent labels Jan 15, 2018

muvarov changed the title ~~[PATCH v12] Misc fixes~~ [PATCH v13] Misc fixes Jan 15, 2018

muvarov added Email_sent and removed Email_sent labels Jan 15, 2018

muvarov closed this Jan 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PATCH v13] Misc fixes #377

[PATCH v13] Misc fixes #377

lumag commented Dec 31, 2017

codecov bot commented Dec 31, 2017 •

edited

Bill-Fischofer-Linaro left a comment

muvarov commented Jan 1, 2018

muvarov commented Jan 1, 2018

muvarov Jan 1, 2018

lumag Jan 1, 2018

lumag commented Jan 1, 2018

muvarov commented Jan 1, 2018

lumag commented Jan 3, 2018

lumag commented Jan 8, 2018

muvarov Jan 14, 2018

lumag Jan 14, 2018

muvarov Jan 14, 2018

muvarov Jan 14, 2018

muvarov Jan 14, 2018

lumag Jan 14, 2018

lumag Jan 14, 2018

muvarov Jan 14, 2018

lumag commented Jan 14, 2018

muvarov commented Jan 15, 2018

		@@ -1,5 +1,7 @@
		include $(top_srcdir)/example/Makefile.inc

		LDADD += $(ATOMIC_LIBS)

[PATCH v13] Misc fixes #377

[PATCH v13] Misc fixes #377

Conversation

lumag commented Dec 31, 2017

codecov bot commented Dec 31, 2017 • edited

Codecov Report

Bill-Fischofer-Linaro left a comment

Choose a reason for hiding this comment

muvarov commented Jan 1, 2018

muvarov commented Jan 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lumag commented Jan 1, 2018

muvarov commented Jan 1, 2018

lumag commented Jan 3, 2018

lumag commented Jan 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lumag commented Jan 14, 2018

muvarov commented Jan 15, 2018

codecov bot commented Dec 31, 2017 •

edited