[PATCH API-NEXT v4] crypto: add new algorithms #434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muvarov
changed the title
Bill-Fischofer-Linaro
suggested changes
Jan 27, 2018
There was a problem hiding this comment.
This looks good. Most of the Checkpatch issues are false positives, but dropping the URLs will fix one "line too long" check.
If PR #422 is a pre-req it needs to have Travis issues resolved first. PR #430 can be merged first and that deleted from v2 of this patch, unless @psavol wants to withdraw it and use this PR's copy.
| static crypto_test_reference_t aes_ccm_reference[] = { | ||
| /* | ||
| * AES-CCM reference from RFC 3610: | ||
| * https://tools.ietf.org/html/rfc3610#section-8 |
There was a problem hiding this comment.
The RFC citation is sufficient. URLs should not be included as they tend to get stale.
| /* | ||
| * Test vector from RFC 7539, sections 2.8.2, A.5: | ||
| * https://tools.ietf.org/html/rfc7539#section-2.8.2 | ||
| * https://tools.ietf.org/html/rfc7539#appendix-A.5 |
There was a problem hiding this comment.
The RFC citation is sufficient.
| @@ -477,6 +606,244 @@ static crypto_test_reference_t aes_gmac_reference[] = { | |||
| }, | |||
| }; | |||
|
|
|||
| /* Test vectors from SP800-38B / CSRC examples: | |||
| * https://csrc.nist.gov/CSRC/media/Projects/Cryptographic-Standards-and-Guidelines/documents/examples/AES_CMAC.pdf | |||
There was a problem hiding this comment.
The NIST SP citation is sufficient. Any reader can easily Google it if needed. URLs tend to get stale quickly, and checkpatch flags it as too long.
|
#422 is not a prereq. |
muvarov
changed the title
Codecov Report
@@ Coverage Diff @@
## api-next #434 +/- ##
============================================
Coverage ? 78.463%
============================================
Files ? 196
Lines ? 35308
Branches ? 0
============================================
Hits ? 27704
Misses ? 7604
Partials ? 0
|
Bill-Fischofer-Linaro
approved these changes
Jan 28, 2018
|
Remaining checkpatch issues are false positives. |
muvarov
changed the title
|
#436 is merged. You can refresh this one. |
added 7 commits
January 30, 2018 19:09
Add enumeration for AES CMAC authentication algorithm. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
ChaCha20-Poly1305 is a promising AEAD algorithm. Add decarations to support it. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Checking that cipher is not NULL was required because GMAC used NULL cipher to specify it's IV. Now it is obosolete, as auths has their own IV. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Merge defines for AES-CBC/CTR/GCM keys. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Neither RFC 3610 nor SP 800-38C contains test vectors for 192 and 256 bit keys and none contains test vectors for 11-bit IV (used in IPsec). So I've used 1st test vector from RFC 3610 and generated the rest of test vectors. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
added 8 commits
January 30, 2018 19:09
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Drop crypto_kind_t, unused now. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
OpenSSL >= 1.1.0 supports ChaCha20-Poly1305 AEAD cipher, so let's support it in linux-generic. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
AES-CCM support in OpenSSL is quite unique: it requires whole data to be passed in single EVP_EncryptUpdate/EVP_DecryptUpdate call. Supporting this requires copying data back-and-forth between packet and temporary buffer. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Point that current authentication functions use HMAC by including hmac in their names. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Support IPsec ChaCha20-Poly1305 on top of linux-generic's crypto support. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
muvarov
changed the title
psavol
approved these changes
Jan 31, 2018
There was a problem hiding this comment.
API modifications OK.
Reviewed-by: Petri Savolainen petri.savolainen@linaro.org
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #430 , incorporating changes from #428 , implementation of CCM (declared at #430) and declaration and implentation of AES-CMAC, requested by our customers. I'd like to get #422 in for TigerMoth. Otherwise we seem more or less complete.