[PATCH v5] travis: build DPDK with clang if it was selected #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muvarov
changed the title
muvarov
changed the title
muvarov
changed the title
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
=============================================
- Coverage 77.774% 77.758% -0.017%
=============================================
Files 199 199
Lines 35766 35766
=============================================
- Hits 27817 27811 -6
- Misses 7949 7955 +6
|
muvarov
reviewed
Jan 31, 2018
.travis.yml
Outdated
| @@ -158,33 +158,40 @@ install: | |||
| if [ "${CACHED_DPDK_VERS}" != "${DPDK_VERS}" ]; then | |||
| rm -rf dpdk | |||
| fi | |||
| - if [ "${CC#clang}" != "${CC}" ] ; | |||
| then | |||
| DPDKCC=clang ; | |||
There was a problem hiding this comment.
why do we need this and not just $CC ?
There was a problem hiding this comment.
It is used to:
- set DPDK target directory (
...-clangvs...-gcc) - set DPDK configuration items based on the toolchain selected
muvarov
reviewed
Jan 31, 2018
| @@ -193,6 +200,7 @@ install: | |||
| sed -i -e 's/40900/40800/g' lib/librte_eal/common/include/arch/arm/rte_vect.h | |||
| sed -i -e 's/!(/!(defined(__arm__) \&\& defined(__clang__) || /g' lib/librte_eal/common/include/arch/arm/rte_byteorder.h | |||
| sed -i -e 's/__GNUC__/defined(__arm__) \&\& defined(__clang__) || __GNUC__/' lib/librte_eal/common/include/generic/rte_byteorder.h | |||
| sed -i -e 's,\$(CC),\0 $(EXTRA_CFLAGS),g' lib/librte_acl/Makefile | |||
There was a problem hiding this comment.
should this go to dpdk instead of odp?
There was a problem hiding this comment.
I know nothing about contributing to DPDK. Also what is the chance of fixing old DPDK releases (which we use)?
There was a problem hiding this comment.
if we push this to dpdk then we will not need to fix it with new releases.
muvarov
changed the title
gcc-built DPDK is not fully compatible with clang (see https://travis-ci.org/lumag/odp/jobs/335324053 for example). Use clang to compile DPDK if selected compiler is clang. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
muvarov
changed the title
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc-built DPDK is not fully compatible with clang (see
https://travis-ci.org/lumag/odp/jobs/335324053 for example). Use clang
to compile DPDK if selected compiler is clang.
Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsolenikov@linaro.org