[PATCH CATERPILLAR v1] linux-gen: add cxgbe RX slot mode support #442
Conversation
To use RX slot_mode one needs to redefine CXGB4_RX_BUF_SIZE_INDEX=2 either in cxgbe4.c locally or via CFLAGS in ./configure One needs supplementary patch on kernel driver applied as well as load kernel driver with rx_mode=1 parameter. Signed-off-by: Mykyta Iziumtsev <mykyta.iziumtsev@linaro.org>
muvarov
changed the title
| #define CXGB4_RX_BUF_SIZE_INDEX_9000 0x3UL | ||
|
|
||
| /* Default RX buffer size index to use */ | ||
| #ifndef CXGB4_RX_BUF_SIZE_INDEX |
There was a problem hiding this comment.
The question is if we need to reverse CXGB4_RX_BUF_SIZE_INDEX <-> CXGB4_RX_BUF_SIZE dependency and have CXGB4_RX_BUF_SIZE as configuration option (possible values at the moment are 2048 and 4096). Probably then it will be more intuitively understandable and we'll hide HW specific index stuff.
That is:
#ifndef CXGB4_RX_BUF_SIZE
#define CXGB4_RX_BUF_SIZE 4096
#endif
CXGB4_RX_BUF_SIZE == 2048 => define CXGB4_RX_BUF_SIZE_INDEX CXGB4_RX_BUF_SIZE_INDEX_1500
CXGB4_RX_BUF_SIZE == 4096 => define CXGB4_RX_BUF_SIZE_INDEX CXGB4_RX_BUF_SIZE_INDEX_4K
There was a problem hiding this comment.
I personally prefer the code as-is. Keeping a notifier for different hardware functionality will be a better indicator for someone reading the code than buffer size values.
|
@muvarov Not clear why the callout for checkpatch reports failure here but the checkpatch run in Travis reports success. |
|
With Ilias' review approve let's merge this to complete caterpillar mediated device driver works. |
To use RX slot_mode one needs to redefine CXGB4_RX_BUF_SIZE_INDEX=2 either
in cxgbe4.c locally or via CFLAGS in ./configure
One needs supplementary patch on kernel driver applied as well as load
kernel driver with rx_mode=1 parameter.
Signed-off-by: Mykyta Iziumtsev mykyta.iziumtsev@linaro.org