Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH v6] changelog: updates for v1.18.0.0 #500

Closed
wants to merge 1 commit into from
Closed

[PATCH v6] changelog: updates for v1.18.0.0 #500

wants to merge 1 commit into from

Conversation

Bill-Fischofer-Linaro
Copy link
Contributor

Add updates for v1.18.0.0 (Tiger Moth RC2)

Signed-off-by: Bill Fischofer bill.fischofer@linaro.org

@muvarov muvarov changed the title changelog: updates for v1.18.0.0 [PATCH v1] changelog: updates for v1.18.0.0 Feb 26, 2018
@Bill-Fischofer-Linaro
Copy link
Contributor Author

Posted for initial review. Do not merge yet. I will update this after PR #497 and any other PRs that are needed for RC2 are merged.

lumag
lumag suggested changes Feb 26, 2018
View reviewed changes
CHANGELOG Outdated
The `odp_pktio_open()` API may now specify devices of class `null` to indicate
the PktIO is treated as a dummy device. Null devices behave just like Linux
`/dev/null` in that they never receive packets and simply discard any packets
sent to them.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted, that there are/might be implementations that do not provide null PktIO

CHANGELOG Outdated
`odp_crypto_op_param_t` is replaced by a separate `cipher_iv_ptr` and
`auth_iv_ptr` fields.

* The special nature of GCM and GMAC cipher and authentication algorithms is
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below. GCM, CCM, ChaCha20-Poly1305 are not "cipher and authentication" algorithms. They are "authenticated encryption" modes/algorithms.

CHANGELOG Outdated
Cannot run l2fwd application on Cavium ThunderX platform

==== https://bugs.linaro.org/show_bug.cgi?id=3517[Bug 3517]
timer test might fail
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be fixed before RC2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed today, this must be fixed before Tiger Moth release. RC2 is just the API freeze level.

CHANGELOG Outdated
timer test might fail

==== https://bugs.linaro.org/show_bug.cgi?id=3597[Bug 3597]
new generator test assumes that null:0 pktio is always present
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fixed already

CHANGELOG Outdated
ODP linux generic fails on AArch64 in non-ABI-compat mode

==== https://bugs.linaro.org/show_bug.cgi?id=3628[Bug 3628]
Another timer_main failure
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed before RC2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, should be fixed before Tiger Moth release. RC2 is API freeze level, so this doesn't affect any APIs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug 3628 fixed, line has to be removed.

@codecov
Copy link

codecov bot commented Feb 27, 2018 •
edited

Codecov Report

Merging #500 into next will decrease coverage by 0.414%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              next      #500       +/-   ##
=============================================
- Coverage   78.054%   77.639%   -0.415%     
=============================================
  Files          177       188       +11     
  Lines        36563     40684     +4121     
=============================================
+ Hits         28539     31587     +3048     
- Misses        8024      9097     +1073
Impacted Files Coverage Δ
test/validation/api/timer/timer.c 76.656% <0%> (-2.209%) ⬇️
example/generator/odp_generator.c 42.42% <0%> (-1.147%) ⬇️
platform/linux-generic/pktio/ipc.c 78.323% <0%> (-0.29%) ⬇️
platform/linux-generic/_ishm.c 67.239% <0%> (-0.265%) ⬇️
platform/linux-generic/odp_timer_wheel.c 88.497% <0%> (-0.235%) ⬇️
platform/linux-generic/odp_traffic_mngr.c 78.989% <0%> (-0.043%) ⬇️
test/validation/api/chksum/chksum.c 97.222% <0%> (ø)
platform/linux-generic/odp_ipsec.c 87.788% <0%> (ø)
helper/cuckootable.c 85.815% <0%> (ø)
helper/chksum.c 78.145% <0%> (ø)
... and 7 more

@Bill-Fischofer-Linaro
Copy link
Contributor Author

Bill-Fischofer-Linaro commented Feb 27, 2018 •
edited

@muvarov I've reposted this PR but for some reason it's not being identified as v2. This is actually v2. Changes:

  • Rebased to latest next branch
  • Incorporate review comments by @lumag
  • Pick up latest API change:odp_packet_data_seg_len()

A v3 will follow depending on what other PRs get merged before RC2 freezes.

@lumag lumag mentioned this pull request Feb 27, 2018
Closed
@muvarov muvarov changed the title [PATCH v1] changelog: updates for v1.18.0.0 [PATCH v2] changelog: updates for v1.18.0.0 Feb 27, 2018
@muvarov muvarov changed the title [PATCH v2] changelog: updates for v1.18.0.0 [PATCH v3] changelog: updates for v1.18.0.0 Feb 27, 2018
@muvarov muvarov changed the title [PATCH v3] changelog: updates for v1.18.0.0 [PATCH v4] changelog: updates for v1.18.0.0 Feb 28, 2018
@Bill-Fischofer-Linaro
Copy link
Contributor Author

Changes in v4:

  • Added selectable scheduler and ring-based queues (PRs to be part of RC2)
  • Updated bug list for recently merged fixes

muvarov
muvarov reviewed Mar 2, 2018
View reviewed changes
CHANGELOG Outdated
==== https://bugs.linaro.org/show_bug.cgi?id=3602[Bug 3602]
validation: cls: capability field is not checked for test cases

==== https://bugs.linaro.org/show_bug.cgi?id=3611[Bug 3611]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3611 fixed, has to be removed. @lumag please confirm from your side.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, 3611 is not fixed.

muvarov
muvarov reviewed Mar 2, 2018
View reviewed changes
CHANGELOG Outdated
==== https://bugs.linaro.org/show_bug.cgi?id=3245[Bug 3245]
Cannot run l2fwd application on Cavium ThunderX platform

==== https://bugs.linaro.org/show_bug.cgi?id=3602[Bug 3602]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug 3602 is not a but. It's just remided to Bala. Entry in changelog has to be removed.

muvarov
muvarov reviewed Mar 2, 2018
View reviewed changes
CHANGELOG Outdated
==== https://bugs.linaro.org/show_bug.cgi?id=3210[Bug 3210]
packet header parsing routines should verify header checksums

==== https://bugs.linaro.org/show_bug.cgi?id=3245[Bug 3245]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug 3245 is not related to linux-generic. Has to be remove from changelog.

muvarov
muvarov reviewed Mar 2, 2018
View reviewed changes
CHANGELOG Outdated
==== https://bugs.linaro.org/show_bug.cgi?id=2988[Bug 2988]
ODP exposes symbols outside of odp*/_odp* namespace

==== https://bugs.linaro.org/show_bug.cgi?id=3210[Bug 3210]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug 3210 looks like improvement not a bug. I would remove it from changelog also.

@muvarov muvarov changed the title [PATCH v4] changelog: updates for v1.18.0.0 [PATCH v5] changelog: updates for v1.18.0.0 Mar 2, 2018
@muvarov muvarov removed the Email_sent label Mar 2, 2018
@muvarov muvarov removed the checkpatch label Mar 2, 2018
@Bill-Fischofer-Linaro
Copy link
Contributor Author

Changes for v5:

  • Removed references to bugs 3210, 3245, 3602, and 3611 as requested.

muvarov
muvarov reviewed Mar 2, 2018
View reviewed changes
CHANGELOG Outdated
ODP exposes symbols outside of odp*/_odp* namespace

==== https://bugs.linaro.org/show_bug.cgi?id=3628[Bug 3628]
Another timer_main failure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timer is merged. https://bugs.linaro.org/show_bug.cgi?id=3628

@Bill-Fischofer-Linaro
changelog: updates for odp v1.18.0.0
f85f34d 
Add updates for v1.18.0.0 (Tiger Moth RC2)

Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
@muvarov muvarov changed the title [PATCH v5] changelog: updates for v1.18.0.0 [PATCH v6] changelog: updates for v1.18.0.0 Mar 2, 2018
@muvarov muvarov removed the checkpatch label Mar 2, 2018
@Bill-Fischofer-Linaro
Copy link
Contributor Author

Changes for v6:

  • Restored Bug 3611 as fixed
  • Moved Bug 3628 to fixed

@muvarov
Copy link
Contributor

muvarov commented Mar 2, 2018

Merged.

@muvarov muvarov closed this Mar 2, 2018
@lumag
Copy link

lumag commented Mar 2, 2018

@muvarov @Bill-Fischofer-Linaro 3611 is not fixed, so changelog should be corrected.

@Bill-Fischofer-Linaro
Copy link
Contributor Author

Bill-Fischofer-Linaro commented Mar 3, 2018 •
edited

PR #509 created to correct Changelog for v1.18.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumag lumag lumag requested changes

@muvarov muvarov muvarov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bill-Fischofer-Linaro @muvarov @lumag