core: add support for test case variants #227
Conversation
In some cases (Android CTS) test come with different variants. Test variants are identified with [foo] at the end of the test name. The string in the brackets can contain slashes. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@linaro.org>
mwasilew
force-pushed
the
fix_cts_parsing
branch
from
4c2e0c0
to
089ec0d
Compare
| name = '/'.join(parts[index:]) | ||
| else: | ||
| group_name = '/'.join(parts[0:-1]) | ||
| name = parts[-1] |
There was a problem hiding this comment.
I was skeptical that this algorithm worked in all cases but I added some tests and couldn't find any bugs (see danrue@b1df44c if you want to add them). Even so, I think it might have be simpler to pull out the [string] using a regex or similar rather than a loop.
|
It comes from CTS (the problem we have), but doesn't have to be specific to CTS. I can imagine tests with variants (values vector) that are represented in brackets. The only problem is that we consider "/" as a special character. CTS doesn't do that and I didn't come up with any better idea how to solve the problem. We could propose the fix to CTS, but I doubt it would be accepted :) |
|
the code looks ok to me as well. I am a bit concerned about having so support any arbitrary naming convention out in the world, but let's go for this one for now |
In some cases (Android CTS) test come with different variants. Test
variants are identified with [foo] at the end of the test name. The
string in the brackets can contain slashes.
Signed-off-by: Milosz Wasilewski milosz.wasilewski@linaro.org