frontend: migrate all templates to Jinja2 #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All templates (web, email, txt) were migrated to Jinja2, except those in 'squad/templates/django' due to lack of support of Django Rest Framework along with Jinja. Bellow are a few items worth mentioning: - migrated all .html templates to .jinja2 using Jinja2's syntax - kept templatetags, decorating them as global functions and filters, following Jinja2 guidelines - adjusted settings.py to work properly with Jinja2 - created squad/jinja2.py, that loads default filters from Django and load squad's custom templatetags - left rest_framework/api.html and squad/_user_menu.html unchanged since Django Rest Framework does NOT support jinja2, nor it's going to be supporting (didn't see any) issue addressing that on their repo to date - some extra if's had to be added given that django sometimes fail silently (tag 'with') whereas jinja doesn't. Found several templates that were crashing after migrated to Jinja
chaws
force-pushed
the
migrate-templates-to-jinja2
branch
from
64c60af
to
dfe3d0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All templates (web, email, txt) were migrated to Jinja2, except those in
'squad/templates/django' due to lack of support of Django Rest Framework
along with Jinja. Bellow are a few items worth mentioning:
using Jinja2's syntax
and filters, following Jinja2 guidelines
from Django and load squad's custom templatetags
unchanged since Django Rest Framework does NOT support
jinja2, nor it's going to be supporting (didn't see any)
issue addressing that on their repo to date
fail silently (tag 'with') whereas jinja doesn't. Found several
templates that were crashing after migrated to Jinja