Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New search bug when using absolute paths and when moving documents #65

Closed
kura opened this issue Sep 7, 2022 · 0 comments
Closed

New search bug when using absolute paths and when moving documents #65

kura opened this issue Sep 7, 2022 · 0 comments

Comments

@kura
Copy link
Contributor

kura commented Sep 7, 2022 •
edited
Loading

I spotted 2 bugs in the new search code after leaving it running in my home lab.

  1. When the wiki documents directory is an absolute path the watchdog indexer stores the abs path rather than rel path, breaking links in the results page. It works when an index_all() is called but not via the natural create/update functionality that the watchdog handles.
  2. Moving a document between directories causes the old document to remain in the index until a full reindex is done 'cos I didn't implement on_moved event handling... :(

Both of these should be pretty easy fixes, I'll work on a patch over lunch later today.
kura added a commit to kura/wikmd that referenced this issue Sep 7, 2022
@kura
Fixes/changes for Linbreux#65
8d646d4 
Fixes:
* Rel paths causing abs paths to break when indexing documents

Adds:
* Ability for indexing moved documents. Without this change documents that are moved remain in the search index until a fresh index is created.
  This fixes that and correctly calls a delete() on the old path and index() on the new path.
kura added a commit to kura/wikmd that referenced this issue Sep 7, 2022
@kura
Fixes/changes for Linbreux#65
3913c75 
Fixes:
* Rel paths causing abs paths to break when indexing documents

Adds:
* Ability for indexing moved documents. Without this change documents that are moved remain in the search index until a fresh index is created.
  This fixes that and correctly calls a delete() on the old path and index() on the new path.
kura added a commit to kura/wikmd that referenced this issue Sep 7, 2022
@kura
Fixes/changes for Linbreux#65
984ae3f 
Fixes:
* Rel paths causing abs paths to break when indexing documents
* git_manager git add --all

Adds:
* Ability for indexing moved documents. Without this change documents that are moved remain in the search index until a fresh index is created.
  This fixes that and correctly calls a delete() on the old path and index() on the new path.
Linbreux added a commit that referenced this issue Sep 7, 2022
@Linbreux
Merge pull request #66 from kura/fix-search-abspath
970b500 
Fixes/changes for #65
@Linbreux Linbreux closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kura @Linbreux