Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded CAS in main syscall path #163

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Remove unneeded CAS in main syscall path #163

merged 5 commits into from
Apr 10, 2024

Conversation

rennergade
Copy link
Contributor

Description

Fixes # (issue)

Removes compare and swap from main syscall path. Not need in Linux because of no vmhole (see note in code).

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

All test suites and LAMP apps.

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

yizhuoliang
yizhuoliang approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@yizhuoliang yizhuoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like you said, if this thing doesn't interleave in Linux, then breaking down the CAS makes perfect sense.

yzhang71
yzhang71 approved these changes Apr 10, 2024
View reviewed changes
Copy link

@yzhang71 yzhang71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is LGTM!

RusherRG
RusherRG approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@RusherRG RusherRG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense and the comment explains why we need to remove it

@rennergade rennergade merged commit dc64bf1 into develop Apr 10, 2024
1 check failed
rennergade added a commit that referenced this pull request Apr 24, 2024
@rennergade
Remove unneeded CAS in main syscall path (#163)
0f3963b 
* change suspend CAS

* change suspend CAS

* change suspend CAS

* change sign

* change sign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhang71 yzhang71 yzhang71 approved these changes

@RusherRG RusherRG RusherRG approved these changes

@yizhuoliang yizhuoliang yizhuoliang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rennergade @yzhang71 @RusherRG @yizhuoliang