Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy updates #138

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Lazy updates #138

merged 1 commit into from
Jun 30, 2022

Conversation

rennergade
Copy link
Contributor

Fixes issues for OnceCell and SyncLazy since they have been renamed in the latest rust update.

@rennergade rennergade changed the base branch from main to develop June 23, 2022 19:26
Copy link
Contributor

@kapkic kapkic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OnceLock seems to be failing in Actions.

@rennergade
Copy link
Contributor Author

OnceLock seems to be failing in Actions.

Yeah, so the Rust devs decided to rename these in nightly for the latest release. So with older rustup nightly versions this fix won't work, but if we don't have this it won't work in the future. Seems crazy that they renamed these mid-version without any real disclaimer.

Anyways, this is one of the things inspiring the docker updates.

Copy link
Contributor

@justyoyo123 justyoyo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand, looks good to me.

Copy link
Contributor

@Devansh-Patel Devansh-Patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rennergade rennergade merged commit 5cb5988 into develop Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants