Accept comments #292
Open
Accept comments #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidge20
requested review from
rennergade,
yashaswi2000,
qianxichen233,
Anway-Agte,
ve1nard,
rupeshkoushik07 and
namanlalitnyu
|
@ve1nard requesting your review, thanks |
davidge20
removed request for
rennergade,
yashaswi2000,
qianxichen233,
Anway-Agte,
rupeshkoushik07 and
namanlalitnyu
davidge20
commented
Jul 8, 2024
|
@pranav-bhatt can you take a look at this one as well |
ve1nard
reviewed
Jul 12, 2024
davidge20
commented
Jul 15, 2024
| match filedesc_enum { | ||
| Socket(ref mut sockfdobj) => { | ||
| //Clone the socket handle as it may be in use by other threads and | ||
| //obtain a read lock, blocking the calling thread until | ||
| //there are no other writers that hold the lock | ||
| let sock_tmp = sockfdobj.handle.clone(); | ||
| let mut sockhandle = sock_tmp.read(); |
There was a problem hiding this comment.
Does it have to be a mutable read guard? I deleted the mut keyword and all the tests still passed.
(Thank you Qianxi for pointing it out)
|
@rupeshkoushik07 requesting your review, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
All functions related to and including accept_syscall were commented out
Type of change
How Has This Been Tested?
Will add test cases if necessary
Checklist: