-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test and comments for poll_syscall #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tests! Left some minor comments for more context and typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just two minor comments.
Very thorough tests!
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, really great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment but this is good to go. Great job!
Description
This PR added several tests and comments for poll_syscall. The test being added is very simliar to select_syscall, as both syscalls serve a very similar purpose.
Fixes # (issue)
Several minor issues in poll_syscall are fixed in this PR:
Type of change
How Has This Been Tested?
ut_lind_net_poll_bad_input
ut_lind_net_poll_timeout
ut_lind_net_poll
(this test is marked as ignore since an unfixed bug will panick the test)Checklist: