Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Removal of IRC hooks #23

Closed
wants to merge 2 commits into from

Conversation

MrBitKoin
Copy link
Contributor

-Removed the IRC source files
-Updated Qt Creator project to not include irc source.
-Removed command line test for -irc

-Updated Qt Creator project to not include irc source.
-Removed command line test for -irc
@nisanb
Copy link
Collaborator

nisanb commented Feb 11, 2018

Did you also remove all dependencies from other sources?
example: net.cpp, line 1678 -
threadGroup.create_thread(boost::bind(&TraceThread<void (*)()>, "irc", &ThreadIRCSeed));

-Also removed(commented) the irc.h include as it was overlooked
@MrBitKoin
Copy link
Contributor Author

Forgot to add the file from the stage. Either way I had forgotten to comment out the #include "irc.h" so was good I had to go back and look. Thank you.

@nisanb
Copy link
Collaborator

nisanb commented Feb 11, 2018

Awesome. Did you compile to check there are no other dependencies included?

@nisanb
Copy link
Collaborator

nisanb commented Feb 15, 2018

Hi. I've added the code changes required for the IRC deprecation at pull request #25
Please close this pull request as it is a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants