LIN-161 - unit tests for node transformer. #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionsardesai
force-pushed
the
LIN-161-unit-node-transformer
branch
from
50ac61e
to
a068771
Compare
lionsardesai
changed the title
yifanwu
reviewed
Jan 14, 2022
There was a problem hiding this comment.
Had some questions. The biggest concern is around the extensive use of mocks. Behavioral assertions make low level assumptions about implementation details, making it more time consuming to maintain and are harder to read. I vote for more functional assertions and if we can't do it, we should refactor our code. Happy to continue the discussion on Slack!
…sues with older versions.
…of code to proceed. (mocking that out for now)
lionsardesai
force-pushed
the
LIN-161-unit-node-transformer
branch
from
e85651a
to
8bac28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes LIN-161
Type of change
Please delete options that are not relevant.
new test cases
How Has This Been Tested?
unit tests added to tests/unit/transformer/*