Change submodules to https endpoints #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes submodules to https endpoints to remove requirement for public key authentication to install lineapy in non-authenticated environments (for example, docker build)
yifanwu
reviewed
Jun 9, 2022
.gitmodules
Outdated
| ignore = all | ||
| [submodule "tests/integration/sources/tensorflow-decision-forests"] | ||
| path = tests/integration/sources/tensorflow-decision-forests | ||
| url = git@github.com:tensorflow/decision-forests.git | ||
| url = https://github.com/tensorflow/decision-forests.git | ||
| ignore = all |
There was a problem hiding this comment.
Thanks for the fix, Chris! I just noticed some weird indentations and will fix it directly and merge!
minor indentation fix for formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes submodules to https endpoints to remove the requirement for
public key authentication to install lineapy from source in environments
that do not have GitHub ssh authentication enabled.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally in a Docker environment.