Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

批曰。編譯有誤 #403

Closed
2 tasks done
cuixiping opened this issue Dec 26, 2019 · 4 comments
Closed
2 tasks done

批曰。編譯有誤 #403

cuixiping opened this issue Dec 26, 2019 · 4 comments
Labels
syntax Suggestions to improve the syntax

Comments

@cuixiping
Copy link
Contributor

cuixiping commented Dec 26, 2019

Describe your issue/suggestions

批曰。「「吾嘗觀「「易經」」之書」」

編譯得

/*"易經"*/

而應得

/* 吾嘗觀「「易經」」之書 */

另外,建議增加塊注釋(block comment)

長批曰。
    ……
    ……
    ……
長批至此。

Checklist

Before you create this issue, Please make sure ALL the following items are checked

  • If this is a feature request, it's NOT listed Here
  • If this is a bug report, it's NOT listed Here
@LingDong-
Copy link
Member

Hi @cuixiping ,

Nested 「「 are not supported yet, but will be among my very next things to add.

I think once we support that, then we already have block comments:

注曰「「
一行
一行
又一行
三四五六七八行
」」

Thanks!

@LingDong- LingDong- added the syntax Suggestions to improve the syntax label Dec 26, 2019
@LingDong-
Copy link
Member

Now nested comment is supported: 32b0f3a
You can nest comments as much as you like:

批曰。「「「吾」嘗觀「「「易」經」」之「「「書」」」」」

However, the 「」's need to be matched even inside the comment. Otherwise there is no way for the parser to see where the comment ends.

Thanks!

@cuixiping
Copy link
Contributor Author

Great!

@antfu antfu mentioned this issue Dec 28, 2019
@antfu
Copy link
Member

antfu commented Dec 30, 2019

Fixed in v0.1.2. Closing now. Feel free to reopen it if you got any questions.

@antfu antfu closed this as completed Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
syntax Suggestions to improve the syntax
Projects
None yet
Development

No branches or pull requests

3 participants