Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails on Node 12.13.0 #42

Closed
pheyvaer opened this issue Nov 28, 2019 · 4 comments
Closed

Build fails on Node 12.13.0 #42

pheyvaer opened this issue Nov 28, 2019 · 4 comments

Comments

@pheyvaer
Copy link

Building the code on Node 12.13.0 fails, while it still works on 10.17.0.
@RubenVerborgh
Copy link
Member

New version of NAN is likely to help.

@mielvds
Copy link
Collaborator

mielvds commented Dec 3, 2019

I can confirm the issue. Do we bump the nan version because this also blocks building the LDF server for instance.

@rubensworks
Copy link
Member

This issue appears to be a duplicate of #41.

@mielvds mielvds mentioned this issue Dec 3, 2019
Closed
@mielvds
Copy link
Collaborator

mielvds commented Dec 4, 2019

also fixed by #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rubensworks @RubenVerborgh @mielvds @pheyvaer