-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated NAN to 2.14 #43
Updated NAN to 2.14 #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! But can we also update .travis.yml
to include 11
, 12
, 13
, lts/*
, node/*
? (cfr. https://github.com/rdfjs/N3.js/blob/7bbfb84e2d650edf896792c76ad7da1e5436fa3c/.travis.yml)
"node/*" or "node"? |
Both. |
Ok, looks like they removed
|
Deprecation is fine for now; unless NAN already has an alternative. |
They do: https://github.com/nodejs/nan/blob/master/doc/maybe_types.md#nanset I'll see if it's much work |
latest commit enables building for 13 as well |
Okay the |
Fixes #41 and makes HDT-Node compatible with Node 12.
Not sure about the backwards compatibility now, to be tested.