-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to rdfjs #44
Conversation
Thanks! Do you happen to have any insights in performance regressions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks excellent.
Pinging @mielvds and @rubensworks for a review. Note: is semver major. |
Didn't do any testing yet (other than the test suite), so can't say much about the performance. Good thing is that the majority of the work in this pr (the test suite) is useful regardless of the solution (c vs js) we end up with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot @LaurensRietveld. Leaving #45 to do some checks before we release. |
And update the docs... |
See #35
What changed:
searchTriples
function)fromFile
What still needs to be done after this PR: