Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_json integration #300

Open
khider opened this issue Jan 25, 2023 · 2 comments
Open

to_json integration #300

khider opened this issue Jan 25, 2023 · 2 comments
Assignees

Comments

@khider
Copy link
Member

khider commented Jan 25, 2023

Is your feature request related to a problem? Please describe.
Ability to save to json files

Describe the solution you'd like
Right now, the json implementation is not at the API level. Would be nice to allow for it

@khider
Copy link
Member Author

khider commented Jan 25, 2023

Enabled for the Series object in fd24e07. Needs to be done for other objects after #298 is complete

@khider
Copy link
Member Author

khider commented Jan 28, 2024

Fixing this issue will also fix #408 and #298

Right now, the json utils are low-level utility functions that need to be accessed through the utils API. This presents significant issues: (1) need to import the package within the json utils module to avoid circular importing (making import of Pyleoclim slow), (2) can't properly check for valid keys in the objects. Putting at the API level would solve this problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant