Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play nice with existing helpers. AMD friendly modules format #33

Closed
wants to merge 1 commit into from

Conversation

jimmyhchan
Copy link
Contributor

The diff is hard to see but here's what we got

@jimmyhchan
Copy link
Contributor Author

this works but the core dust changes are not ready to support this.

some things i don't like:

  • this is setup in it's own require wrapper but it is not really a module in that it is somewhat useless without dust.
  • on the other hand, is this adequately similar to the jQuery "plugin" model

@rragan
Copy link
Contributor

rragan commented May 13, 2013

The original issue seems to have been closed but there is no resolution in the code. Can you elaborate what it means that the core dust changes are not ready to support this? I guess this line might be the problem:
dust.helpers = {};

Wouldn't a simple exists check before definition in core dust + the changes that were submitted as a PR here do the trick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants