Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS support #20

Merged
merged 5 commits into from
Apr 13, 2020
Merged

MacOS support #20

merged 5 commits into from
Apr 13, 2020

Conversation

sallaben
Copy link
Contributor

Adds MacOS >=10.15 support to flutter_web_auth.

Please let me know if you have any questions or suggestions!

@sallaben
Copy link
Contributor Author

I would suggest browsing the difference by commit.

cfceb4d has the class itself
0e0c773 has /example/macos files
26180cb has GIF of macos behavior.

@sallaben
Copy link
Contributor Author

sallaben commented Apr 7, 2020

@LinusU would like to use this in my project and I'm sure others would too :)

@LinusU
Copy link
Owner

LinusU commented Apr 7, 2020

Sorry for the delay, will try to take a look this weekend 👀

@sallaben
Copy link
Contributor Author

sallaben commented Apr 12, 2020

Hey, any luck? (i promise this is my last bump tho)

@@ -25,8 +25,14 @@ flutter:
# be modified. They are used by the tooling to maintain consistency when
# adding or updating assets for this project.
plugin:
androidPackage: com.linusu.flutter_web_auth
pluginClass: FlutterWebAuthPlugin
platforms:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks older versions of Flutter so I will release this as a breaking change

@LinusU
Copy link
Owner

LinusU commented Apr 13, 2020

(i promise this is my last bump tho)

Don't feel bad bumping! I have 321 unread notifications that I still have to get to right now, and many of them are just noise, so this puts it at the top 😅

I'm pushing some fixups directly to your branch, for future reference please don't bump the version in the PR, I want to do that in a separate commit. (in fact, I'm automating it with emoji-commit)

Also I would recommend to configure your editor to automatically insert final newline character to avoid this:

Screenshot 2020-04-13 at 10 26 01

and to remove trailing whitespace to avoid this:

Screenshot 2020-04-13 at 10 27 24

I also ran ImageOptim on the images to save some space, trimmed a few frames from the gif, added macOS info to the readme and some other minor cleanups.

@LinusU LinusU merged commit 7289dd1 into LinusU:master Apr 13, 2020
@LinusU
Copy link
Owner

LinusU commented Apr 13, 2020

Thank you so much for this 🎉

@LinusU
Copy link
Owner

LinusU commented Apr 13, 2020

Released as 🚢 0.2.0 / 2020-04-13

@eldadfux
Copy link

Great work!! @LinusU @sallaben 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants