-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS support #20
MacOS support #20
Conversation
@LinusU would like to use this in my project and I'm sure others would too :) |
Sorry for the delay, will try to take a look this weekend 👀 |
Hey, any luck? (i promise this is my last bump tho) |
@@ -25,8 +25,14 @@ flutter: | |||
# be modified. They are used by the tooling to maintain consistency when | |||
# adding or updating assets for this project. | |||
plugin: | |||
androidPackage: com.linusu.flutter_web_auth | |||
pluginClass: FlutterWebAuthPlugin | |||
platforms: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks older versions of Flutter so I will release this as a breaking change
Don't feel bad bumping! I have 321 unread notifications that I still have to get to right now, and many of them are just noise, so this puts it at the top 😅 I'm pushing some fixups directly to your branch, for future reference please don't bump the version in the PR, I want to do that in a separate commit. (in fact, I'm automating it with emoji-commit) Also I would recommend to configure your editor to automatically insert final newline character to avoid this: and to remove trailing whitespace to avoid this: I also ran ImageOptim on the images to save some space, trimmed a few frames from the gif, added macOS info to the readme and some other minor cleanups. |
Thank you so much for this 🎉 |
Released as 🚢 0.2.0 / 2020-04-13 |
Adds MacOS >=10.15 support to
flutter_web_auth
.Please let me know if you have any questions or suggestions!