Fix #15 always terminate 'authenticate' callbacks on Android #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enables androidX and jetifier for non-androidx libs - also upgrades Gradle wrappers to 6.3 - also upgrade Android Gradle plugins to 3.6.3 - also sets Kotlin version of both lib + example to 1.3.72
- If custom tabs are closed on Android, the Future of `authenticated` function will never complete. We can solve that by registering a WidgetsBindingObserver before the actual call happens. If the app is resumed we can then look for all active callbacks, and remove them (because otherwise they would never complete). - We remove the WidgetsBindingObserver again each time, because that could have side-effects on the calling app. - Also updated the sample code to reflect that `authenticate` can and will fail with a PlatformException when the user aborts. - Also cleaned up the Kotlin code a bit because this was fun :-)
…ever-completed-on-android
- improves readability, as there was *another* callback with the same name in the same scope
|
Sorry for not getting to this earlier, I will try to get to it this weekend! ❤️ |
|
Thank you! 🎉 |
|
@LinusU any update on this? Thanks a lot :) |
|
@LinusU can we get this merged in? |
|
Sorry for the delay, merging and releasing now! 🎉 Thanks for the PR ❤️ |
|
Released in 🚢 0.2.3 / 2020-05-11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.