fix: consider having a lockfile #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should've always been here, esp the build script. had to read through [1] to figure it out smh [1] https://medium.com/jspoint/a-simple-guide-to-load-c-c-code-into-node-js-javascript-applications-3fcccf54fd32 Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
NB! PR based on LinusU#42 which would need to get merged first. don't know if you use npm or yarn - I chose yarn here but you can change it. regardless, the lockfile should be committed, unless you have a good reason not to? Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
I think that best practice is to not commit the lock file for libraries that are published to npm. When a package is published to Npm the lock file is ignored, and thus you'll end up testing against older versions whereas people using your package will always use the latest... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB! PR based on #42 which would need to get merged first.
don't know if you use npm or yarn - I chose yarn here but you can change it.
regardless, the lockfile should be committed, unless you have a good reason not to?
Signed-off-by: Kipras Melnikovas kipras@kipras.org