Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bless on arm64 Fixes #204 #205

Merged
merged 1 commit into from
Mar 17, 2022
Merged

bless on arm64 Fixes #204 #205

merged 1 commit into from
Mar 17, 2022

Conversation

cybergrind
Copy link
Contributor

No description provided.

lib/appdmg.js Outdated Show resolved Hide resolved
lib/appdmg.js Show resolved Hide resolved
Copy link
Owner

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just to linting nits, I thought I could apply them myself but that option seems to be missing 馃

If you can just add them I'm happy to merge and release right away 馃殌

Thank you for working on this!

@cybergrind
Copy link
Contributor Author

@LinusU fixed. sorry, for some reason eslint didn't catch up config

@LinusU LinusU merged commit 3f2c8bd into LinusU:master Mar 17, 2022
@LinusU
Copy link
Owner

LinusU commented Mar 17, 2022

Thanks! Released as 馃殺 0.6.3 / 2022-03-17

erickzhao added a commit to electron-userland/electron-installer-dmg that referenced this pull request Mar 24, 2022
This fixes an issue with building on ARM64 devices running macOS 12.3.
See LinusU/node-appdmg#205 for details.
malept pushed a commit to electron-userland/electron-installer-dmg that referenced this pull request Mar 24, 2022
* chore: bump appdmg to ~0.6.4

This fixes an issue with building on ARM64 devices running macOS 12.3.
See LinusU/node-appdmg#205 for details.

* ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants