Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for macOS #14

Merged
merged 2 commits into from Feb 16, 2021
Merged

Add support for macOS #14

merged 2 commits into from Feb 16, 2021

Conversation

ospfranco
Copy link
Contributor

needed support for react-native-macos, since the code is simple and has no platform specific dependencies simply adding it seems to make it work... but only with the debugger connected (which makes me think it will only work on a production build, which I cannot test right now) seems related to: uuidjs/uuid#416

@LinusU
Copy link
Owner

LinusU commented Sep 3, 2020

Hmmm, if it only works with the debugger connected I think it is because it's falling back to Math.random, which means that it will not work on a production build. This probably needs some more investigation...

@ospfranco
Copy link
Contributor Author

Hey, sorry, I completely forgot about this and I'm just taking a look one more time, you are absolutely right, the fact that only works with the debugger attached is not good.

However I'm not really a macOS/iOS developer, but do you have any idea what could be going wrong, some pointer would be useful to start taking a loook

@ospfranco
Copy link
Contributor Author

Turns out I did a small mistake, when importing the package it was not my first import but I imported it after my react-native modules, by moving in on top of my index.js file everything is working fine! so this PR can me merged

@ospfranco
Copy link
Contributor Author

Hello? can we merge this PR?

@ospfranco
Copy link
Contributor Author

@LinusU

@ospfranco ospfranco changed the title Add osx as supported platform Add support for macOS Feb 13, 2021
@ospfranco
Copy link
Contributor Author

Pinging one more time for this PR to be merged

@LinusU LinusU merged commit 3fe766c into LinusU:master Feb 16, 2021
@LinusU
Copy link
Owner

LinusU commented Feb 16, 2021

sorry for the delay

@LinusU
Copy link
Owner

LinusU commented Feb 16, 2021

Released as 🚢 1.6.0 / 2021-02-16

@0xMillz
Copy link

0xMillz commented Sep 30, 2023

This closes issue #10

@LinusU LinusU mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants