Add IA2_SCROLL_TYPE_*MIDDLE scrolling types #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add IA2_SCROLL_TYPE_MIDDLE, IA2_SCROLL_TYPE_HORIZONTAL_MIDDLE, and IA2_SCROLL_TYPE_VERTICAL_MIDDLE. These have become necessary for scrolling web page pieces into view because the top or bottom of pages are now very often hidden under banners and webbrowser have a hard time detecting that, as discussed on: https://bugzilla.mozilla.org/show_bug.cgi?id=1572680 Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
|
I'm not sure if we want the separate horizontal and vertical versions, I guess e.g. Orca would only use the middle version. |
|
(perhaps we'd rather name it "center" instead of "middle") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IA2_SCROLL_TYPE_MIDDLE, IA2_SCROLL_TYPE_HORIZONTAL_MIDDLE, and
IA2_SCROLL_TYPE_VERTICAL_MIDDLE.
These have become necessary for scrolling web page pieces into view because
the top or bottom of pages are now very often hidden under banners and
webbrowser have a hard time detecting that, as discussed on:
https://bugzilla.mozilla.org/show_bug.cgi?id=1572680
Signed-off-by: Samuel Thibault samuel.thibault@ens-lyon.org