Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEGL Effects Continual Edition - Always Clip #8

Open
mmBesar opened this issue Dec 21, 2023 · 45 comments
Open

GEGL Effects Continual Edition - Always Clip #8

mmBesar opened this issue Dec 21, 2023 · 45 comments

Comments

@mmBesar
Copy link

mmBesar commented Dec 21, 2023

The GEGL Effects Continual Edition always Clip, even with Adjust is selected, The GEGL Effects on the other hand does not have this problem.
I like the features of GEGL Effects Continual Edition more, but to use it, I have to adjust the Layer Boundary Size.
My OS is Fedora 39 and GIMP from Flatpak.
Thank you for this great project.

@LinuxBeaver
Copy link
Owner

I'm fully aware of this. It has to do with gegl:crop being present inside GEGL Effects Continual's newer features to prevent other bugs. If the crop was not present those newer features would have other bugs due to technicalities with GEGL.

After typing text in Gimp select "layer to image size"
image

image

then apply GEGL Effects continual and the clipping will be gone.


Now I will explain the technical reason on what is going on. (regardless if anyone understands)

gegl:color is used to recolor the text to anything regardless of its original color. However gegl:color and other "render"GEGL operations; (like gegl:cell-noise, and gegl:checkerboard ect...) create an infinite sized canvas and gegl:crop is used to cancel the infinite canvas. If I removed all gegl:crop nodes and recompiled the bug clipping would go away at the expense of a worse bug. The color update bug The color update bug is a bug you likely haven't seen because of the crop cancelling it. But here is a description of the color update bug.

THE FORMER COLOR UPDATE BUG DESCRIPTION
This bug is no longer present in any of my modern filters, but use to exist. A minute or so after using GEGL Effects the user will try to change the color of the text, or anything and it will not update until the user moves an unrelated slider. IE I would change the color of the text in the GUI and it would stay unchanged until I moved a Inner Glow slider. Crop solves that bug at the expense of a slightly less problematic bug that can be solved with "layer to image size"

Both bugs (color update and clipping) has to do with GEGL entirely and Pippin is probably the only one who could solve it. I just chain basic GEGL operations to create new meta operations. I don't use math to manipulate pixels like Pippin does.

@mmBesar
Copy link
Author

mmBesar commented Jan 18, 2024

Thank you for the clear answer, hopefully it will be resolved soon.
Thanks again for such an important project, which should be a native GIMP tool.

@LinuxBeaver
Copy link
Owner

Today might lead to that resolvement as I am testing a unreleased build of GEGL Effects that doesn't clip and lacks bugs. You can test it here. Below is source code and binaries of said update.
gegl_effects_no_clipping_feb_17_code.zip

This update only applies to the stable branch.

*update a few minutes after writing this I confirmed the bug is still there but feel free to test it anyway.
image

I am working hard to resolve this bug.

@LinuxBeaver
Copy link
Owner

image

image

I have no clue why GEGL is doing this.

@LinuxBeaver
Copy link
Owner

After digging deeper I found the alleged culprit.
image

@LinuxBeaver
Copy link
Owner

This is a comedy as once one bug is solved. A new bug springs in its place.
image

@mmBesar
Copy link
Author

mmBesar commented Feb 17, 2024

Tested now, it's working great!
The outline works only when enabled.
I'm on Fedora 39, Flatpak GIMP, with only these effects installed.
Great work, thank you.

@mmBesar
Copy link
Author

mmBesar commented Feb 17, 2024

These effects should be built-in GIMP!

@LinuxBeaver
Copy link
Owner

ok, just remember this build has the legacy bug and it will not be on Github until the bug is resolved.

If you want to see this plugin in Gimp request it here
https://gitlab.gnome.org/GNOME/gimp/-/issues/9327

@LinuxBeaver
Copy link
Owner

and here
https://gitlab.gnome.org/GNOME/gegl/-/issues/343#note_1853016

Jehan said they wanted my layer effects engine in Gimp. But other devs have not yet spoken.

@mmBesar
Copy link
Author

mmBesar commented Feb 17, 2024

ok, just remember this build has the legacy bug and it will not be on Github until the bug is resolved.

I can't see it!

@mmBesar
Copy link
Author

mmBesar commented Feb 17, 2024

If you want to see this plugin in Gimp request it here https://gitlab.gnome.org/GNOME/gimp/-/issues/9327

and here https://gitlab.gnome.org/GNOME/gegl/-/issues/343#note_1853016

Jehan said they wanted my layer effects engine in Gimp. But other devs have not yet spoken.

Done, It's a must for me!

@LinuxBeaver
Copy link
Owner

I just found out native Gimp filters clip too on the upward and left zones.

image

If this is the case then the bug has no ultimate solution. I can only do my best to make sure it does not clip left and up.

Thank you for filing this bug report, as even though I knew about this bug I never took the time to analysis it until now.

@mmBesar
Copy link
Author

mmBesar commented Feb 17, 2024

This is the best text effects in GIMP, thank you for sharing it.

@LinuxBeaver
Copy link
Owner

Hey, use this update. It still has the color delay bug but it is far less common.

gegl_effects_no_clipping_2.zip

@mmBesar
Copy link
Author

mmBesar commented Feb 17, 2024

Hey, use this update. It still has the color delay bug but it is far less common.

gegl_effects_no_clipping_2.zip

Tested and working great, thank you.

@LinuxBeaver
Copy link
Owner

LinuxBeaver commented Feb 18, 2024

After digging very deeply I found out the color update bug and clipping bug are "either or nuisances" and it seems impossible to solve clipping without going back to color update bug. Arranging GEGL nodes will not solve the problem. The plan to fix it now is to see if I can get the graph to update every time specific color nodes are changed. That way the color update bug goes away.

image

@mmBesar
Copy link
Author

mmBesar commented Feb 18, 2024

I noticed the color bug, I'm confident you will find a fix for it.

@LinuxBeaver
Copy link
Owner

Liam is writing code hoping we can get the color to update in real time. gegl effects and its hidden operation zzstrokebevelimage

@LinuxBeaver
Copy link
Owner

No matter what happens the bug will still be solvable in CMYK Student's build by expanding text boxes.

image

@mmBesar
Copy link
Author

mmBesar commented Feb 29, 2024

Liam is writing code hoping we can get the color to update in real time. gegl effects and its hidden operation zzstrokebevelimage

Great news, thank you.

@LinuxBeaver
Copy link
Owner

LinuxBeaver commented Mar 10, 2024

I figured out how to solve in a reasonable way. Image shows how the second crop node will be toggled on and off.

image

GEGL Effects uses a special hidden operation for outlines and shadows called "zzstrokebevelimage" it does not use Gimp's normal gegl:dropshadow. The plan is to make zzstrokebevelimage update with a enable/disable clipping checkbox for its drop shadow. Put simply, GEGL Effects will update with a checkbox in the drop shadow section to enable/disable clipping. In default it has always been enabled but users will be able to easily disable it at the expense of the bug, and make presets where it is disabled.

For example you can keep clip enabled while editing and right before applying the text you can disable clip.

Said update has not happened yet. I'll do it tomorrow.

@LinuxBeaver
Copy link
Owner

Ok here is the new checkbox in zzstrokebevelimage (in GEGL Effects it will be much simpler)

Shadow Clip Enabled as in default
image

Shadow Clip Policy Disabled

image

I am thinking of making it where the checkbox is reverse check to remove clipping.

@LinuxBeaver
Copy link
Owner

Look at the checkbox to enable disable the clip
https://streamable.com/qu40sc

yeah I know the text style is trashy. Its just testing

@LinuxBeaver
Copy link
Owner

image

Here is the GEGL Effects update that is not yet on my main github.

Includes Binaries and Code
gegl_effects_MAIN_PLUGIN_march_10_2024.zip

and here is the code for every other plugin of mine (including GEGL Effects) to be in compliance with CMYK Student's build (code only)
march_10th_all_plugins_code.zip

@mmBesar
Copy link
Author

mmBesar commented Mar 11, 2024

Good idea, well done.

@mmBesar
Copy link
Author

mmBesar commented Mar 11, 2024

Tested now!
Nice, Just disable and re-enable shadow, fixes the color update issue.

@LinuxBeaver
Copy link
Owner

How about you update to the new stable release? It has this and a feature that makes the outline always black so the outline isn't always the same color as the text.

https://github.com/LinuxBeaver/Gimp_Layer_Effects_Text_Styler_Plugin_GEGL_Effects/releases/tag/ContinualMarch102024

This issue is resolved the best way I know how.

@LinuxBeaver
Copy link
Owner

hey, I forgot to mention. GEGL Styles - a special branch of GEGL Effects was officially accepted in Gimp 3 days ago.

image

@mmBesar
Copy link
Author

mmBesar commented Mar 12, 2024

This is great, congrats dear.
These effects are a very important addition to GIMP.

@LinuxBeaver
Copy link
Owner

You can test it now

Go here
https://www.gimp.org/downloads/devel/

image

To launch it run flatpak run --branch=master org.gimp.GIMP and look for "GEGL Styles" in Filters>Generic

@LinuxBeaver
Copy link
Owner

It will probably hit unstable in a week or so. I don't know how things work. I'm lobbying in the GIMP irc to make it happen though.

@mmBesar
Copy link
Author

mmBesar commented Mar 14, 2024

How about you update to the new stable release? It has this and a feature that makes the outline always black so the outline isn't always the same color as the text.

https://github.com/LinuxBeaver/Gimp_Layer_Effects_Text_Styler_Plugin_GEGL_Effects/releases/tag/ContinualMarch102024

This issue is resolved the best way I know how.

No clipping in GIMP, but when exported to a PNG, the clipping appears on the right side!

@mmBesar
Copy link
Author

mmBesar commented Mar 14, 2024

Hey, use this update. It still has the color delay bug but it is far less common.

gegl_effects_no_clipping_2.zip

Even with this version! The clipping is back when exported to PNG file!
Flatpak GIMP 2.99.18
Fedora 39

@LinuxBeaver
Copy link
Owner

Do native Gimp filters do this as well? I know Gimp 2.99.19 has a clip bug.

@LinuxBeaver
Copy link
Owner

image

The same thing happens on native Gimp filters. It is a bug but its not just Styles or Effects, its dropshadow.

@mmBesar
Copy link
Author

mmBesar commented Mar 15, 2024

I was suspecting this!

@LinuxBeaver
Copy link
Owner

LinuxBeaver commented Mar 15, 2024

copy image data to a clipboard and paste it into a clipboard manager. I do that using an app called Zim

https://www.zim-wiki.org/downloads.html

@LinuxBeaver
Copy link
Owner

LinuxBeaver commented May 2, 2024

Please update to the latest version of GEGL Effects. The march 10th series was recalled and the July 22 2023 branch had an update to remove all clipping.

https://github.com/LinuxBeaver/Gimp_Layer_Effects_Text_Styler_Plugin_GEGL_Effects/releases

NO TEXT CLIPPING AND NO CHECKBOX!

image

@mmBesar
Copy link
Author

mmBesar commented May 3, 2024

After a quick test, it looks very good, no issues. Thank you.
But still can't use it with the beta version from Flathub, as it's clipping even the built-in shadow!
Do have a recommended beta version, or a way to use the Flathub beta version?!
Again, thank you for such an important piece of software.

@LinuxBeaver
Copy link
Owner

LinuxBeaver commented May 5, 2024

Please update again. That release had a serious problem. Latest version is here. The color update bug and clip is solved

https://github.com/LinuxBeaver/Gimp_Layer_Effects_Text_Styler_Plugin_GEGL_Effects/releases

The serious problem in May 2 2024 are listed below

  1. The blend mode changer for outline bevel doesn't work due to me adding a state-> in front of the bevel mode

  2. zzstrokebevelimage.c's code was reworked to make it more optional

  3. Image file uploads done twice crash GIMP

Please overwrite all binaries. May 4th 2024 is probably stable

@LinuxBeaver
Copy link
Owner

LinuxBeaver commented May 5, 2024

After a quick test, it looks very good, no issues. Thank you. But still can't use it with the beta version from Flathub, as it's clipping even the built-in shadow! Do have a recommended beta version, or a way to use the Flathub beta version?! Again, thank you for such an important piece of software.

What do you mean by "beta version from Flathub" Are you talking about GEGL Styles? it doesn't clip for me

image

@mmBesar
Copy link
Author

mmBesar commented May 6, 2024

After a quick test, it looks very good, no issues. Thank you. But still can't use it with the beta version from Flathub, as it's clipping even the built-in shadow! Do have a recommended beta version, or a way to use the Flathub beta version?! Again, thank you for such an important piece of software.

What do you mean by "beta version from Flathub" Are you talking about GEGL Styles? it doesn't clip for me

I'm talking about GIMP beta, not the GEGL Styles.
The clipping appears in the exported PNG image!

@LinuxBeaver
Copy link
Owner

LinuxBeaver commented Jun 3, 2024

Please update to the May 28th 2024 build of GEGL Effects. It fixes a problem where GIMP 2.99.19 crashes on close

https://github.com/LinuxBeaver/Gimp_Layer_Effects_Text_Styler_Plugin_GEGL_Effects/releases

Also if you use other plugins of mine then 33 of them have to be updated to so GIMP 2.99.19 no longer crashes on close. If you download this link below it will contain binaries and source code to update GEGL Effects; its binaries and 27 other plugins so they no longer crash when the user closes GIMP 2.99.19.

Download containing GEGL Effects, its stand alones and 27 other plugins that no longer crash on close in GIMP 2.99.19

https://github.com/LinuxBeaver/LinuxBeaver/releases/download/Gimp_GEGL_Plugins_download_page/windows_and_linux_binaries_of_33_updated_plugins.zip

@mmBesar
Copy link
Author

mmBesar commented Jun 4, 2024

Where to get the 2.99.19?! The latest beta on Flathub is 2.99.18!
This unofficial AppImage always crashing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants