Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STEPGEN_MAXVEL config.ini vs documentation vs lintini.py #977

Closed
alkabal opened this issue Nov 15, 2020 · 2 comments
Closed

STEPGEN_MAXVEL config.ini vs documentation vs lintini.py #977

alkabal opened this issue Nov 15, 2020 · 2 comments

Comments

@alkabal
Copy link
Contributor

alkabal commented Nov 15, 2020

Hi

Only something i see checking code for config ini but i'm unsure about issue or not.

STEPGEN_MAXVEL = 1.4 - Older configuration files have a velocity limit for the step generator as well. If specified, it should also be 1% to 10% larger than the joint MAX_VELOCITY. Subsequent testing has shown that use of STEPGEN_MAXVEL does not improve the tuning of stepgen’s position loop.

So reading this i think i can remove this value from my config file but later i see here a check for this value in the code so what is really needed ?

is_stepper = ini.find("JOINT_0", "STEPGEN_MAXVEL")

Br

@alkabal
Copy link
Contributor Author

alkabal commented Nov 15, 2020

At the same time i see something strange in doc vs code source
Thanks for reply

I suspect some typo mistake in documentation :
doc 2.8 Gmoccapy for [TRAJ]
MAX_VELOCITY = 230.000 vs MAX_LINEAR_VELOCITY

doc 2.8 for [TRAJ]
DEFAULT_LINEAR_ACCELERATION = 2.0 vs DEFAULT_ANGULAR_VELOCITY
MAX_LINEAR_ACCELERATION = 20.0 vs MAX_ANGULAR_VELOCITY

doc 2.8 for Display
MIN_VELOCITY = .01 need to be removed because we can found the good one at the bottom (MIN_LINEAR_VELOCITY)

@alkabal
Copy link
Contributor Author

alkabal commented Nov 15, 2020

FInally i see at many place
DEFAULT_LINEAR_ACCELERATION
MAX_LINEAR_ACCELERATION

So this is not a typo error but these value seem to be ignored by pncconf

Really in my opinion these parts need to be clarified (maybee only for my own knowledge)

@alkabal alkabal closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant