-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide configurable properties for max page size and max number of included resources on search results #1868
Comments
If someone sets these too high, there could be memory issues and/or response time issues |
tbieste
added a commit
that referenced
this issue
May 17, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 17, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 18, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 18, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 18, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 18, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 18, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 19, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 19, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 19, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 19, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 19, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
added a commit
that referenced
this issue
May 19, 2021
Issue #1868 - Configurable max page size and max page included resources
I verified this issue by testing the following scenarios while running my local FHIR server with the latest code level:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The maximum page size for a search request is currently set to 1000, and is not configurable. Also, there is no limit on the number of included resources returned in a page for
_include
and_revinclude
searches.Describe the solution you'd like
Configuration properties should be provided for both the maximum page size for a search request, as well as the maximum number of included resources returned in a page for
_include
and_revinclude
searches.Describe alternatives you've considered
None
Acceptance Criteria
At least one acceptance criteria is included.
WHEN a search is executed that has more results than the configured max page size
THEN verify that the search results are paged and the page size is limited to the max page size configured
WHEN a
_revinclude
or_include
search is executed that has more include results for a page than the configured max number of included resourcesTHEN verify that the search fails
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: