Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs/FHIRServerUsersGuide.md for R4 #2

Closed
lmsurpre opened this issue Aug 29, 2019 · 1 comment
Closed

Update docs/FHIRServerUsersGuide.md for R4 #2

lmsurpre opened this issue Aug 29, 2019 · 1 comment
Assignees
@lmsurpre
Milestone
Sprint 3

Comments

@lmsurpre
Copy link
Member

FHIRServerUserGuide is where we document how to download, install, and run the Watson Health FHIR Server. This needs a serious overhaul for the R4 server.
prb112 added a commit that referenced this issue Aug 30, 2019
@prb112
Merge pull request #2 from watson-health-fhir-server/master-candidate4
e252291 
fix for github.com migration
@lmsurpre lmsurpre added this to the Sprint 1 milestone Sep 4, 2019
@lmsurpre lmsurpre modified the milestones: Sprint 1, Sprint 2 Sep 20, 2019
@prb112 prb112 mentioned this issue Sep 27, 2019
Closed
@senthilbak senthilbak assigned senthilbak and lmsurpre and unassigned senthilbak Oct 7, 2019
@prb112 prb112 mentioned this issue Oct 7, 2019
Closed
@lmsurpre lmsurpre modified the milestones: Sprint 2, Sprint 3 Oct 11, 2019
@prb112 prb112 mentioned this issue Oct 22, 2019
Closed
lmsurpre added a commit that referenced this issue Oct 25, 2019
@lmsurpre
issue #285 - remove schematron property references from
408754a 
also removed references to virtual resources as able.  needs more work but thats issue #2.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Oct 25, 2019
@lmsurpre
issue #285 - remove schematron property references from
2542fa9 
also removed references to virtual resources as able.  needs more work but thats issue #2.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Oct 28, 2019
@lmsurpre
issue #2 - condense projects and update FHIRServerUsersGuide.md
90f9a89 
1. moved java classes from `fhir-client-sample` and
`fhir-connectathon-client` into `fhir-client/src/test/java` and deleted
these projects

2. updated FHIRServerUsersGuide

3. organized FHIRConfiguration properties and removed stale properties:
* jsonParserLenient
* jsonParserValidating
* encryption

4. removed stale properties (whclsfRouter and the above) from all
fhir-server-config.json examples

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Oct 28, 2019
@lmsurpre
issue #2 - condense projects and update FHIRServerUsersGuide.md
8fd846a 
1. moved java classes from `fhir-client-sample` and
`fhir-connectathon-client` into `fhir-client/src/test/java` and deleted
these projects

2. updated FHIRServerUsersGuide

3. organized FHIRConfiguration properties and removed stale properties:
* jsonParserLenient
* jsonParserValidating
* encryption

4. removed stale properties (whclsfRouter and the above) from all
fhir-server-config.json examples

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Oct 28, 2019
@lmsurpre
issue #2 - condense projects and update FHIRServerUsersGuide.md
86cc2c4 
1. moved java classes from `fhir-client-sample` and
`fhir-connectathon-client` into `fhir-client/src/test/java` and deleted
these projects

2. updated FHIRServerUsersGuide

3. organized FHIRConfiguration properties and removed stale properties:
* jsonParserLenient
* jsonParserValidating
* encryption

4. removed stale properties (whclsfRouter and the above) from all
fhir-server-config.json examples

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Oct 28, 2019
@lmsurpre
issue #2 - condense projects and update FHIRServerUsersGuide.md
e39f0f6 
1. moved java classes from `fhir-client-sample` and
`fhir-connectathon-clients` into `fhir-client/src/test/java` and deleted
these projects

2. organized FHIRConfiguration properties and removed stale properties:
  * jsonParserLenient
  * jsonParserValidating
  * encryption

3. removed stale properties (whclsfRouter and the above) from all
fhir-server-config.json examples

4. updated FHIRServerUsersGuide
  * removed stale properties from all config snippets and the properties
reference tables in section 5
  * cleared "Recent updates" section and removed link to CHANGELOG
  * updated CapabilityStatement snippet
  * updated some references from WebSphere Liberty to OpenLiberty
  * removed references to liquibase; now we have custom code for
database schema migration.  but documentation in this area needs
significant work, starting with #270


Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112 added a commit that referenced this issue Oct 28, 2019
@prb112
Merge pull request #320 from IBM/issue-2
abb66b9 
issue #2 - condense projects and update FHIRServerUsersGuide.md
@lmsurpre lmsurpre mentioned this issue Oct 31, 2019
Closed
@prb112
Copy link
Contributor

prb112 commented Nov 4, 2019

I reviewed this and it's a-ok.

@prb112 prb112 closed this as completed Nov 4, 2019
lmsurpre added a commit that referenced this issue Feb 5, 2020
@lmsurpre
issue #679 - added FHIRPath Patch spec tests
b93a442 
1. Added FHIRPathSpecTest for executing the spec-provided
FHIRPath Patch test cases. I needed to tweak the test file to work
around our strict interpretation of `ele-1`
which makes empty resources invalid.
I also removed a single fhirpath patch operation from the
`Full Resource` testcase...we currently cannot handle replace of
DomainResource.text.div

2. Added logic to throw UnsupportedOperationException for patches
with nested part values and added corresponding skip logic from the test

3. Added skip logic for 2 other test cases, both with `mode=forwards`
* `Delete Nested Primitive #2`: this test expects that the server will
automatically remove a parent elements when the last element from within
one is removed. We don't do that.
* `Reorder List #4`: on this one, I disagree with the expected output

4. Found and fixed an issue with the original implementation;
patch values for code subtypes come is as basic Code types whereas the
setters expect a subtype, so I needed to add logic to convert the Code
to the appropriate subtype before calling any setters.

Finally, I added the FHIR mimetypes to the patchFormat element of our
CapabilityStatement to indicate that we now support FHIRPath patch.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 5, 2020
@lmsurpre
issue #679 - added FHIRPath Patch spec tests
4b92b56 
1. Added FHIRPathSpecTest for executing the spec-provided
FHIRPath Patch test cases. I needed to tweak the test file to work
around our strict interpretation of `ele-1`
which makes empty resources invalid.
I also removed a single fhirpath patch operation from the
`Full Resource` testcase...we currently cannot handle replace of
DomainResource.text.div

2. Added logic to throw UnsupportedOperationException for patches
with nested part values and added corresponding skip logic from the test

3. Added skip logic for 2 other test cases, both with `mode=forwards`
* `Delete Nested Primitive #2`: this test expects that the server will
automatically remove a parent elements when the last element from within
one is removed. We don't do that.
* `Reorder List #4`: on this one, I disagree with the expected output

4. Found and fixed an issue with the original implementation;
patch values for code subtypes come is as basic Code types whereas the
setters expect a subtype, so I needed to add logic to convert the Code
to the appropriate subtype before calling any setters.

Finally, I added the FHIR mimetypes to the patchFormat element of our
CapabilityStatement to indicate that we now support FHIRPath patch.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 5, 2020
@lmsurpre
issue #679 - added FHIRPath Patch spec tests
ac3e1bd 
1. Added FHIRPathSpecTest for executing the spec-provided
FHIRPath Patch test cases. I needed to tweak the test file to work
around our strict interpretation of `ele-1`
which makes empty resources invalid.
I also removed a single fhirpath patch operation from the
`Full Resource` testcase...we currently cannot handle replace of
DomainResource.text.div

2. Added logic to throw UnsupportedOperationException for patches
with nested part values and added corresponding skip logic from the test

3. Added skip logic for 2 other test cases, both with `mode=forwards`
* `Delete Nested Primitive #2`: this test expects that the server will
automatically remove a parent elements when the last element from within
one is removed. We don't do that.
* `Reorder List #4`: on this one, I disagree with the expected output

4. Found and fixed an issue with the original implementation;
patch values for code subtypes come is as basic Code types whereas the
setters expect a subtype, so I needed to add logic to convert the Code
to the appropriate subtype before calling any setters.

Finally, I added the FHIR mimetypes to the patchFormat element of our
CapabilityStatement to indicate that we now support FHIRPath patch.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@prb112 prb112 mentioned this issue Jul 10, 2020
Closed
@michaelwschroeder michaelwschroeder mentioned this issue Dec 2, 2020
Closed
@michaelwschroeder michaelwschroeder mentioned this issue Apr 22, 2021
Closed
@tbieste tbieste mentioned this issue Jun 2, 2021
Closed
@prb112 prb112 mentioned this issue Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
None yet
Projects
None yet
Milestone
Sprint 3
Development

No branches or pull requests
3 participants
@prb112 @lmsurpre @senthilbak