Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More ibm -> linuxforhealth renaming #3855

Closed
lmsurpre opened this issue Aug 8, 2022 · 1 comment
Closed

More ibm -> linuxforhealth renaming #3855

lmsurpre opened this issue Aug 8, 2022 · 1 comment
Assignees
@lmsurpre
Labels
enhancement New feature or request reindex Resolution of issue will require a $reindex during upgrade

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Aug 8, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
There's a few more code-related locations that we should migrate before our 5.0

  • the 'ibm' directories under fhir-examples (json and xml)
  • ibm-* prefixes for internal search parameters
  • ibm.com URIs in extension URLs

Describe the solution you'd like
No more references to IBM in code artifacts

Describe alternatives you've considered

Acceptance Criteria

References to 'ibm' from the codebase are reduced to a reasonable set. "reasonable" here is up for interpretation, but should not include ibm.com urls in data

Additional context
@lmsurpre lmsurpre added the enhancement New feature or request label Aug 8, 2022
@lmsurpre lmsurpre mentioned this issue Aug 8, 2022
Merged
@lmsurpre lmsurpre self-assigned this Aug 8, 2022
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - remove the 'ibm' level from example paths
3731800 
and rename "ibm-x" index files to "generated-x"

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - remove the 'ibm' level from example paths
afd0ed1 
and rename "ibm-x" index files to "generated-x"

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - update path references in source files
3379a8a 
Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
fixup! issue #3855 - remove the 'ibm' level from example paths
04b1958
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - remove the 'ibm' level from example paths
ac0a5fe 
and rename "ibm-x" index files to "generated-x"

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - update path references in source files
93f4bd2 
Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - remove the 'ibm' level from example paths
d6536eb 
and rename "ibm-x" index files to "generated-x"

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - update path references in source files
b265b2a 
Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - remove "ibm" from prefix for internal compartment params
dc733e0 
and various other updates to avoid "ibm-" references in the code

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - remove "ibm" from prefix for internal search params
1c5252d 
1. ibm-internal-X-Compartment -> internal-X-Compartment
2. ibm_composite_X -> internal-composite-X

And various other updates to avoid "ibm-" references in the code.

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - remove "ibm" from prefix for internal search params
ea9aafb 
1. ibm-internal-X-Compartment -> internal-X-Compartment
2. ibm_composite_X -> internal-composite-X

And various other updates to avoid "ibm-" references in the code.

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 9, 2022
@lmsurpre
issue #3855 - remove "ibm" from prefix for internal search params
36cf7ae 
1. ibm-internal-X-Compartment -> internal-X-Compartment
2. ibm_composite_X -> internal-composite_X

And various other updates to avoid "ibm-" references in the code.

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 10, 2022
@lmsurpre
issue #3855 - replace ibm.com extension base with linuxforhealth.org
4254760 
and the base URI that we use for our server-defined extended operations

In both cases, http://ibm.com/fhir became http://fhir.linuxforhealth.org

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 10, 2022
@lmsurpre
issue #3855 - replace "ibm.com" with "example.com" in tests
e528df7 
The one place I left ibm.com URLs is the cql tests which have extensions from ibm.com/fhir/cdm
... those should be updated as well but not until that IG is available with a different base url

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 10, 2022
@lmsurpre
issue #3855 - replace "ibm.com" with "example.com" in tests
28a520a 
The one place I left ibm.com URLs is the cql tests which have extensions
from ibm.com/fhir/cdm
... those should be updated as well but not until that IG is available
with a different base url

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 10, 2022
@lmsurpre
issue #3855 - replace "ibm.com" with "example.com" in tests
1e212ef 
The one place I left ibm.com URLs is the cql tests which have extensions
from ibm.com/fhir/cdm
... those should be updated as well but not until that IG is available
with a different base url

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 11, 2022
@lmsurpre
issue #3855 - replace "ibm.com" with "example.com" in tests
7429414 
The one place I left ibm.com URLs is the cql tests which have extensions
from ibm.com/fhir/cdm
... those should be updated as well but not until that IG is available
with a different base url

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 11, 2022
@lmsurpre
issue #3855 - replace "ibm.com" with "example.com" in tests
550ca06 
The one place I left ibm.com URLs is the cql tests which have extensions
from ibm.com/fhir/cdm
... those should be updated as well but not until that IG is available
with a different base url

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 11, 2022
@lmsurpre
Merge pull request #3864 from LinuxForHealth/issue-3855
c8bcc15 
issue #3855 - remove the 'ibm' level from example paths
lmsurpre added a commit that referenced this issue Aug 11, 2022
@lmsurpre
Merge pull request #3865 from LinuxForHealth/issue-3855-b
651df7b 
issue #3855 - remove "ibm" from prefix for internal compartment params
lmsurpre added a commit that referenced this issue Aug 11, 2022
@lmsurpre
Merge pull request #3868 from LinuxForHealth/issue-3855-c
29d630a 
issue #3855 - replace ibm.com in all canonical uris
@lmsurpre lmsurpre added the reindex Resolution of issue will require a $reindex during upgrade label Aug 15, 2022
lmsurpre added a commit that referenced this issue Aug 16, 2022
@lmsurpre
issue #3855 - remove a few more ibm references
310eb45 
Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Aug 17, 2022
@lmsurpre
Merge pull request #3889 from LinuxForHealth/lee-main-3
ff969a1 
issue #3855 - remove a few more ibm references
@punktilious
Copy link
Collaborator

QA:

  1. There are no ibm directories under fhir-examples
  2. There are no unnecessary instances of the prefix ibm- in the codebase
  3. There is one unnecessary instance of ibm.com in the codebase.

However, for item (3) in SearchExtensionsTest:

                .extension(Extension.builder()
                        .url(EXTENSION_BASE_URL + "favorite-uri")
                        .value(uri("http://www.ibm.com"))
                        .build())

as this is just a unit test, there is no leak of this value in the product runtime. The test can be cleaned up at a convenient time in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
enhancement New feature or request reindex Resolution of issue will require a $reindex during upgrade
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmsurpre @punktilious