Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connectathon Issues with Bulkdata #67

Closed
prb112 opened this issue Sep 14, 2019 · 4 comments
Closed

Connectathon Issues with Bulkdata #67

prb112 opened this issue Sep 14, 2019 · 4 comments
Assignees
@prb112 @lmsurpre @albertwang-ibm
Labels
bug Something isn't working
Milestone
Sprint 1

Comments

@prb112
Copy link
Contributor

prb112 commented Sep 14, 2019

Connectathon Issues with Bulkdata
@prb112
Copy link
Contributor Author

prb112 commented Sep 14, 2019

resolving ds issue and tenant issue with Albert

albertwang-ibm added a commit that referenced this issue Sep 14, 2019
@albertwang-ibm
issue #67 fix fhir tenant issue
543d278 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
prb112 added a commit that referenced this issue Sep 14, 2019
@prb112
Connectathon Issues with Bulkdata #67
3fc46da 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Sep 14, 2019
@prb112
Connectathon Issues with Bulkdata #67
2d5426b 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
lmsurpre added a commit that referenced this issue Sep 14, 2019
@lmsurpre
Merge pull request #68 from IBM/issue-67-aw
9d4a157 
issue #67 fix fhir tenant issue
lmsurpre added a commit that referenced this issue Sep 14, 2019
@lmsurpre
Merge pull request #69 from IBM/issue-67-pb
f2b226c 
Connectathon Issues with Bulkdata #67
albertwang-ibm added a commit that referenced this issue Sep 14, 2019
@albertwang-ibm
issue #67 change file path in COS
d118c91 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
lmsurpre added a commit that referenced this issue Sep 14, 2019
@lmsurpre
Merge pull request #70 from IBM/issue-67-pb
732bc2b 
issue #67 change file path in COS
albertwang-ibm added a commit that referenced this issue Sep 14, 2019
@albertwang-ibm
issue #67 change importchunkjob to take tenant and storeID
697b4a9 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
lmsurpre added a commit that referenced this issue Sep 14, 2019
@lmsurpre
Merge pull request #71 from IBM/issue-67-aw
571c518 
issue #67 change importchunkjob to take tenant and storeID
albertwang-ibm added a commit that referenced this issue Sep 14, 2019
@albertwang-ibm
issue #67 add org.json to javabatchjob war
7cc1f4f 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
lmsurpre added a commit that referenced this issue Sep 14, 2019
@lmsurpre
Merge pull request #72 from IBM/issue-67-aw
9565105 
issue #67 add org.json to javabatchjob war
@prb112 prb112 mentioned this issue Sep 14, 2019
Closed
albertwang-ibm added a commit that referenced this issue Sep 15, 2019
@albertwang-ibm
issue #67 for test
d677e81 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Sep 15, 2019
@albertwang-ibm
issue #67 disable the check
2b3f897 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Sep 15, 2019
@albertwang-ibm
issue #67 fix tab
3c8acdc 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Sep 15, 2019
@albertwang-ibm
issue #67 remove set configdir
31ea8bf 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Sep 15, 2019
@albertwang-ibm
issue #67 remove shared jar from jobbatch war
4a055e3
albertwang-ibm added a commit that referenced this issue Sep 15, 2019
@albertwang-ibm
issue #67 remove shared jar from jobbatch war
28cd745 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
lmsurpre added a commit that referenced this issue Sep 15, 2019
@lmsurpre
Merge pull request #74 from IBM/issue-#67-new
038e929 
issue #67 remove shared jar from jobbatch war
albertwang-ibm added a commit that referenced this issue Sep 15, 2019
@albertwang-ibm
issue #67 add datastoreID support to the batchjobs
4438cb9 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Sep 15, 2019
@albertwang-ibm
issue #67 fix bulkdata unittest issue
10a298b 
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
@lmsurpre
Copy link
Member

Once we finally started testing with a partner, we hit a few issues where we returned 400 error when it was actually a server error. This was frustrating to user and made it harder for him to trust us when we rejected other requests with the same error (even those really were client issues).
We really need to default unexpected exceptions to 500.

@lmsurpre
Copy link
Member

lmsurpre commented Sep 15, 2019 •
edited

Separate thought...I don't think we need to be appending each resources into a big string. Can we buffer the objects on their way into ObjectStore instead? Is there a better way to handle it via java batch?

lmsurpre added a commit that referenced this issue Sep 15, 2019
@lmsurpre
issue #67 - fix ndjson implementation
0bc8e4f 
albert was mislead by the slide deck.  json shouldn't be wrapped in '[
]' and no commas between lines

also we should use Generator and not toString for writing objects

Signed-off-by: lmsurpre <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Sep 15, 2019
@lmsurpre
issue #67 - return absolute url for job status checks
9665f2f 
Signed-off-by: lmsurpre <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Sep 15, 2019
@lmsurpre
Merge pull request #78 from IBM/issue-#67-new
0bf7bda 
Issue #67 new
@prb112
Copy link
Contributor Author

prb112 commented Sep 16, 2019

Once we finally started testing with a partner, we hit a few issues where we returned 400 error when it was actually a server error. This was frustrating to user and made it harder for him to trust us when we rejected other requests with the same error (even those really were client issues).
We really need to default unexpected exceptions to 500.

Sure - I think we consider this part of refactoring.

@prb112 prb112 added this to the Sprint 1 milestone Sep 16, 2019
@prb112 prb112 added the bug Something isn't working label Sep 16, 2019
@prb112 prb112 closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

@lmsurpre lmsurpre

@albertwang-ibm albertwang-ibm

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 1
Development

No branches or pull requests
3 participants
@prb112 @lmsurpre @albertwang-ibm