issue #2169 - change getValueConstant to getValueAsEnum and update project code #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
force-pushed
the
lee-main
branch
2 times, most recently
from
33085a9
to
95d0533
Compare
prb112
reviewed
Apr 27, 2021
prb112
reviewed
Apr 27, 2021
fhir-search/src/main/java/com/ibm/fhir/search/util/ReferenceUtil.java
Outdated
Show resolved
Hide resolved
prb112
approved these changes
Apr 27, 2021
lmsurpre
force-pushed
the
lee-main
branch
2 times, most recently
from
d699abe
to
caa436f
Compare
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
And convert from for loop to a switch. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit has the model change (getValueConstant -> getValueAsEnum) and not much else.
I suggest focusing on the second commit for the review.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com