issue #2535 - wrap exceptions instead of losing them #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to their OperationOutcomeIssues, we now include the original exception in the CausedBy of the FHIRRestBundledRequestException. This way, if the FHIROperationException was unexpected and has no corresponding issues, when it gets mapped to a 500 Server Error we will automatically log the exception from FHIRResource.exceptionResponse(FHIROperationException, Status). Also changed "bundle request" to "bundled request" in FHIRRestHelper.logBundleRequestCompletedMsg to match the language at the start of the bundled request and to make it more clear its the individual bundled entry that completed and not the entire bundle. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to copying their OperationOutcomeIssues, we now include the original
exception in the CausedBy of the FHIRRestBundledRequestExceptions created in
FHIRRestHelper.processEntriesByMethod.This way, if the FHIROperationException was unexpected and has no
corresponding issues, when it gets mapped to a 500 Server Error we will
automatically log the exception from
FHIRResource.exceptionResponse(FHIROperationException, Status).
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com