-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load UMLS data into TermGraph and allow triggering in cloud container #2795
Conversation
...m-graph/src/main/java/com/ibm/fhir/term/graph/loader/impl/SnoMedICD10MapTermGraphLoader.java
Outdated
Show resolved
Hide resolved
...m-graph/src/main/java/com/ibm/fhir/term/graph/loader/impl/SnoMedICD10MapTermGraphLoader.java
Outdated
Show resolved
Hide resolved
...m-graph/src/main/java/com/ibm/fhir/term/graph/loader/impl/SnoMedICD10MapTermGraphLoader.java
Outdated
Show resolved
Hide resolved
...m-graph/src/main/java/com/ibm/fhir/term/graph/loader/impl/SnoMedICD10MapTermGraphLoader.java
Outdated
Show resolved
Hide resolved
...m-graph/src/main/java/com/ibm/fhir/term/graph/loader/impl/SnoMedICD10MapTermGraphLoader.java
Outdated
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/impl/UMLSTermGraphLoader.java
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/impl/UMLSTermGraphLoader.java
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/impl/UMLSTermGraphLoader.java
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/util/COSObject.java
Outdated
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/util/COSObject.java
Outdated
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/util/COSObject.java
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/util/COSObject.java
Outdated
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/util/COSObject.java
Outdated
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/util/COSObject.java
Outdated
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/util/ConfigLoader.java
Outdated
Show resolved
Hide resolved
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/loader/util/ConfigLoader.java
Show resolved
Hide resolved
fhir-term-graph/src/main/resources/conf/janusgraph-cassandra-elasticsearch.properties
Outdated
Show resolved
Hide resolved
...m-graph/src/main/java/com/ibm/fhir/term/graph/loader/impl/SnoMedICD10MapTermGraphLoader.java
Outdated
Show resolved
Hide resolved
Compilation failures |
Good stuff! |
Signed-off-by: Adam T. Clark <atclark@us.ibm.com>
Signed-off-by: Adam T. Clark <atclark@us.ibm.com>
Signed-off-by: Adam T. Clark <atclark@us.ibm.com>
Signed-off-by: Adam T. Clark <atclark@us.ibm.com>
c277b6a
to
0a1dc81
Compare
Signed-off-by: Adam T. Clark <atclark@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Adam T. Clark <atclark@us.ibm.com>
<dependency> | ||
<groupId>com.ibm.cos</groupId> | ||
<artifactId>ibm-cos-java-sdk</artifactId> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were already using this in fhir-bulkdata-webapp, but this is a new dependency for the fhir-server-webapp. I think it pulls in much of the aws sdk.
Since its not actually needed by the server during runtime, I think we should work to split out this new loading tool work so that it doesn't end up in the webapp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed #2799
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I read that as more of creating a utility class to encapsulate the code that accesses COS. i didn't think it went quite as far as what i'm suggesting here which is to split fhir-term-graph into two totally separate modules:
- the loading stuff the creates/populates the graph db
- the provider stuff that uses the graph and ships with the server
Signed-off-by: Adam T. Clark <atclark@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ibmatc !
These changes enable loading UMLS data (Concepts, Relationships, and now map edges between Snomed and ICD) into FHIR TermGraph. This also includes example yml for setting up Cassandra and ElasticSearch for JanusGraph to use.
Signed-off-by: Adam T. Clark atclark@us.ibm.com