Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 3044 - use correct TransformerFactory impl class #3045

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

punktilious
Copy link
Collaborator

Signed-off-by: Robin Arnold robin.arnold@ibm.com

Fixes #3044.

Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had tried leaving this configurable per the design of these XML factories, but I agree it makes more sense just to instantiate a known-good impl since we know there are issues with other implementations. LGTM.

Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@@ -493,3 +493,282 @@ If there is data in the DOMAINRESOURCE and RESOURCE table groups, which is unexp


FHIR® is the registered trademark of HL7 and is used with the permission of HL7.


# Physical Data Model
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some great doc! did you mean to include it in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spoke with robin and this was an accident, but I think its fine to include for now even though its still work-in-progress

Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmsurpre lmsurpre merged commit 10bff20 into main Nov 29, 2021
@lmsurpre lmsurpre deleted the issue-2266-revised branch November 29, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants