Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2694 update schema design docs #3215

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Issue 2694 update schema design docs #3215

merged 4 commits into from
Jan 31, 2022

Conversation

punktilious
Copy link
Collaborator

No description provided.

Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@lmsurpre
Copy link
Member

I love the new schema image...I think I'll be frequently pointing folks at that one.


To optimize certain queries, the `RESOURCE_ID` for the most recent version of a resource is referenced from the `[resourceType]_LOGICAL_RESOURCES` table with the `CURRENT_RESOURCE_ID` column. This is not enforced by a foreign key because the `[resourceType]_LOGICAL_RESOURCES` record is created first and already contains the intended value of the current `RESOURCE_ID` which has been obtained from a sequence. This approach avoids an extra `UPDATE` on `[resourceType]_LOGICAL_RESOURCES` which is expensive during ingestion.

The IBM FHIR Server uses soft-delete when processing a FHIR `DELETE` interaction. This creates a new version of the resource with a minimal resource data value and the `IS_DELETED` flag = `Y`. Soft-deletes do not delete existing database records. The Patient Erase custom operation can be used to remove all traces of a patient from a database.
Copy link
Member

@lmsurpre lmsurpre Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to duplicate the content toward the end of line 89, but maybe its fine?

…ster branch

Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious punktilious added the ci-skip Skips the CI Build label Jan 28, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@lmsurpre lmsurpre self-requested a review January 29, 2022 21:03
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmsurpre lmsurpre merged commit e1b68bf into main Jan 31, 2022
@lmsurpre lmsurpre deleted the issue-2694 branch January 31, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-skip Skips the CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants