issue #2886 - remove useStoredCompartmentParam property #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
changed the title
This compatibility config property is from 4.5.1 and its time to remove this optionality from the code. Also updated tests and docs. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
tbieste
approved these changes
Mar 8, 2022
| } | ||
| } | ||
| ``` | ||
| As of version 5.0.0, compartment membership is always evaluated during ingestion, even if the search parameters that define compartment membership have been filtered out in fhir-server-config.json. |
There was a problem hiding this comment.
I think "As of IBM FHIR Server 5.0.0,..." would be clearer as far as which version is being talked about.
There was a problem hiding this comment.
Suggested change
| As of version 5.0.0, compartment membership is always evaluated during ingestion, even if the search parameters that define compartment membership have been filtered out in fhir-server-config.json. | |
| As of IBM FHIR Server 2022-1, compartment membership is always evaluated during ingestion, even if the search parameters that define compartment membership have been filtered out in fhir-server-config.json. |
There was a problem hiding this comment.
actually, let me get this change into my next PR since I've already made a local commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compatibility config property is from 4.5.1 and its time to
remove this optionality from the code.
Also updated tests and docs.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com