issue #535 - Deduplicate the SearchParameter map #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the parameter maps built by ParametersUtil had each SearchParameter listed twice...once by "code" and once by "url". This pull request introduces a new ParametersMap object that encapsulates two separate maps and presents it as a single object. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112
reviewed
Dec 24, 2019
fhir-search/src/main/java/com/ibm/fhir/search/parameters/ParametersUtil.java
Show resolved
Hide resolved
prb112
reviewed
Dec 24, 2019
fhir-search/src/main/java/com/ibm/fhir/search/parameters/ParametersUtil.java
Show resolved
Hide resolved
prb112
reviewed
Dec 24, 2019
fhir-search/src/main/java/com/ibm/fhir/search/parameters/ParametersUtil.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Dec 24, 2019
fhir-search/src/main/java/com/ibm/fhir/search/parameters/ParametersUtil.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Dec 24, 2019
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Dec 24, 2019
prb112
approved these changes
Dec 24, 2019
1. factored out common logic into private methods in SearchUtil 2. removed incorrect FHIRParserException warning in ParametersUtil.loadBuiltIns 3. removed `continue` in favor of else block in ParametersUtil.buildSearchParametersMapFromBundle Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the parameter maps built by ParametersUtil had each
SearchParameter listed twice...once by "code" and once by "url".
This pull request introduces a new ParametersMap object that
encapsulates two separate maps and presents it as a single object.
Also removed the notion of "UNSUPPORTED_EXPRESSION" since
4.0.1 artifacts now have valid FHIRPath and our FHIRPath engine
now supports
resolve().Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com