Remove x12 delimiter from segment group and segment data models #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "delimiters" field from the X12SegmentGroup and X12Segment models. "delimiters" are removed as there aren't part of the data payload, but rather metadata which drives x12 output and transformation.
The X12SegmentGroup.x12() method now supports a
custom_delimiters
parameter which allows a client to pass customer delimiters if neededSigned-off-by: Dixon Whitmire dixonwh@gmail.com
closes #35