Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using apache/skywalking-eye to do the license checking work #207

Merged
merged 5 commits into from Sep 6, 2023

Conversation

hellojukay
Copy link
Contributor

No description provided.

@hellojukay
Copy link
Contributor Author

#202

Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hellojukay , thanks for helping on this issue.

I'm wondering if this file .licenserc.yaml is required. See also

https://github.com/apache/skywalking-eyes?tab=readme-ov-file#github-actions

.github/workflows/license-check.yaml Outdated Show resolved Hide resolved
@LinuxSuRen LinuxSuRen linked an issue Sep 6, 2023 that may be closed by this pull request
@LinuxSuRen
Copy link
Owner

Sorry about the version part. I checked the version again. It need the prefix v.

image

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@LinuxSuRen
Copy link
Owner

Consider the CI errors should caused by convert sub-command instead of this PR. I'm going to merge this PR.

And welcome @hellojukay to be the 9th contributor!!!

@LinuxSuRen LinuxSuRen changed the title Create license-check.yaml Using apache/skywalking-eye to do the license checking work Sep 6, 2023
@LinuxSuRen LinuxSuRen merged commit c582610 into LinuxSuRen:master Sep 6, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support checking the license header
2 participants