Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https://github.com/bcicen/grmon #63 #70

Merged
merged 4 commits into from
Oct 8, 2021
Merged

Add https://github.com/bcicen/grmon #63 #70

merged 4 commits into from
Oct 8, 2021

Conversation

rexdivakar
Copy link
Contributor

@rexdivakar rexdivakar commented Oct 8, 2021

Added the template config/bcicen/grmon.yml

@rexdivakar
Copy link
Contributor Author

there was no GitHub publish assert, so i assumed you would build it directly over the source repo

@LinuxSuRen
Copy link
Owner

My bad. There's no release yet. But you can use a field fromSource to allow install it from the source.

See bcicen/grmon#11

@LinuxSuRen
Copy link
Owner

By the way, please feel free to add it to this repo if you know any awesome tools.

@LinuxSuRen
Copy link
Owner

This should be a bug of hd:

panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/linuxsuren/http-downloader/pkg.(*ReleaseClient).GetLatestPreReleaseAsset(0xc0000e9950, 0x7fffff44a6c5, 0x6, 0x7fffff44a6cc, 0x5, 0xc00008f7c0, 0xc0000f45a0, 0xc00008f848)
	/home/runner/work/http-downloader/http-downloader/pkg/release.go:71 +0x23e
github.com/linuxsuren/http-downloader/pkg.(*ReleaseClient).GetLatestAsset(0xc0000e9950, 0xc00008f701, 0xa97abf, 0x5, 0xec1840)

@rexdivakar
Copy link
Contributor Author

Yeah, any idea how i could handle it ?

@LinuxSuRen
Copy link
Owner

Yeah, any idea how i could handle it ?

That issue should not block this PR. We can merge this PR.

If you'd like to fix that bug, please check the following code lines.

https://github.com/LinuxSuRen/http-downloader/blob/0c7630d61adc610665d1470b8a0ce25f09328533/pkg/release.go#L71

@rexdivakar
Copy link
Contributor Author

Thanks @LinuxSuRen please merge the PR i will take a look at that repo too

@LinuxSuRen
Copy link
Owner

Awesome!!!

@LinuxSuRen LinuxSuRen merged commit 8c20841 into LinuxSuRen:master Oct 8, 2021
@LinuxSuRen LinuxSuRen linked an issue Oct 9, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add https://github.com/bcicen/grmon
2 participants