feat: add a flag to check version (#357)

Co-authored-by: rick <LinuxSuRen@users.noreply.github.com>
LinuxSuRen · Feb 20, 2023 · 4d6f7ad · 4d6f7ad
1 parent d669e7f
commit 4d6f7ad
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/cmd/install.go b/cmd/install.go
@@ -89,15 +89,18 @@ func (o *installOption) shouldInstall() (should, exist bool) {
 	var greater bool
 	if name, lookErr := o.execer.LookPath(o.tool); lookErr == nil {
 		exist = true
-		versionCmd := "version"
+
+		var versionCmd string
 		if o.downloadOption != nil && o.downloadOption.Package != nil && o.downloadOption.Package.VersionCmd != "" {
 			versionCmd = o.downloadOption.Package.VersionCmd
 		}
 
-		log.Println("check target version via", name, versionCmd)
-		if data, err := o.execer.Command(name, versionCmd); err == nil &&
-			(o.downloadOption.Package != nil && o.downloadOption.Package.Version != "") {
-			greater = version.GreatThan(o.downloadOption.Package.Version, string(data))
+		if versionCmd != "" {
+			log.Println("check target version via", name, versionCmd)
+			if data, err := o.execer.Command(name, versionCmd); err == nil &&
+				(o.downloadOption.Package != nil && o.downloadOption.Package.Version != "") {
+				greater = version.GreatThan(o.downloadOption.Package.Version, string(data))
+			}
 		}
 	}
 	should = o.force || !exist || greater

diff --git a/cmd/install_test.go b/cmd/install_test.go
@@ -134,7 +134,8 @@ func TestShouldInstall(t *testing.T) {
 			},
 			downloadOption: &downloadOption{
 				Package: &installer.HDConfig{
-					Version: "v1.2.4",
+					Version:    "v1.2.4",
+					VersionCmd: "-v",
 				},
 			},
 			tool: "fake",