Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parameterize support to generic package #333

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

LinuxSuRen
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #333 (827b97b) into master (00eae5a) will increase coverage by 2.68%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   55.49%   58.17%   +2.68%     
==========================================
  Files          60       60              
  Lines        3038     3094      +56     
==========================================
+ Hits         1686     1800     +114     
+ Misses       1269     1205      -64     
- Partials       83       89       +6     
Flag Coverage Δ
unittests 58.17% <95.45%> (+2.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/os/generic_installer.go 58.59% <95.00%> (+50.90%) ⬆️
pkg/os/fake/fake.go 100.00% <100.00%> (ø)
cmd/get.go 63.50% <0.00%> (-0.24%) ⬇️
pkg/os/installer.go 85.48% <0.00%> (+4.83%) ⬆️
pkg/installer/process.go 45.98% <0.00%> (+8.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LinuxSuRen LinuxSuRen merged commit e1055a7 into master Jan 29, 2023
@LinuxSuRen LinuxSuRen deleted the feat/param-generic-pkg branch January 29, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant